starred/dehydrated
1
0
Fork 0
mirror of https://github.com/dehydrated-io/dehydrated.git synced 2026-01-11 22:30:44 +01:00
Code Issues 79 Packages Projects Releases 10 Wiki Activity

Order finalization should check that the order is "valid" before trying to download the certificate #432

New Issue
Closed
opened 2025-12-29 01:25:03 +01:00 by adam · 2 comments
adam commented 2025-12-29 01:25:03 +01:00
Owner
Copy Link

Originally created by @alexzorin on GitHub (Sep 10, 2019).

When dehydrated posts its CSR to the order finalization URL, it assumes that the certificate will be signed and immediately available for download in the response:

018254974c/dehydrated (L870-L871)

However, the order may be in any number of states other than validsuch as processing, where dehydrated should wait and poll until the certificate is ready for download.

Currently, dehydrated assumes the certificate field is always present which leads to an error. This error can be reproduced by running dehydrated against Pebble.

Originally created by @alexzorin on GitHub (Sep 10, 2019). When dehydrated posts its CSR to the order finalization URL, it assumes that the certificate will be signed and immediately available for download in the response: https://github.com/lukas2511/dehydrated/blob/018254974cb6cbf93ba9249b06b2d923e37a9e88/dehydrated#L870-L871 However, the order may be [in any number of states](https://tools.ietf.org/html/rfc8555#page-48) other than `valid`such as `processing`, where dehydrated should wait and poll until the certificate is ready for download. Currently, dehydrated assumes the `certificate` field is always present which leads to an error. This error can be reproduced by running dehydrated against Pebble.
adam added the bug label 2025-12-29 01:25:03 +01:00
adam closed this issue 2025-12-29 01:25:03 +01:00
adam commented 2025-12-29 01:25:04 +01:00
Author
Owner
Copy Link

@Rogdham commented on GitHub (Mar 30, 2020):

See #728 for a possible fix.

@Rogdham commented on GitHub (Mar 30, 2020): See #728 for a possible fix.
adam commented 2025-12-29 01:25:04 +01:00
Author
Owner
Copy Link

@lukas2511 commented on GitHub (Apr 2, 2020):

Fixed by #728, thanks.

@lukas2511 commented on GitHub (Apr 2, 2020): Fixed by #728, thanks.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Complicated
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
 suggestions wanted
testing
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/dehydrated#432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?