[PR #137] [CLOSED] load config in cleanup function #728

New Issue

adam · 2025-12-29T01:28:41+01:00

adam commented

2025-12-29 01:28:41 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/137
Author: @olf
Created: 2/15/2016
Status: ❌ Closed

Base: master ← Head: cleanupfix

📝 Commits (10+)

e022f60 add sample hook script that restarts nginx upon successful cert creation
cec4bd6 rename sample hook script
9e320b0 rename hook script (again) to comply with the other example files
9795668 minor
6662209 fix typo in test.sh (ngrok not found)
c928a11 Merge remote-tracking branch 'upstream/master'
aa23109 Merge branch 'upstream'
9439741 Merge branch 'upstream'
5aff16b Merge remote-tracking branch 'upstream/master'
a2a6559 changed the way SCRIPTDIR is searched for so it works better with symbolic links (e.g. a symbolic link in ~/.bin)

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 letsencrypt.sh (+2 -0)

📄 Description

Cleanup wouldn't work for me, if the config isn't loaded in command_cleanup()

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/137 **Author:** [@olf](https://github.com/olf) **Created:** 2/15/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cleanupfix` --- ### 📝 Commits (10+) - [`e022f60`](https://github.com/dehydrated-io/dehydrated/commit/e022f60af5c6fb420979d54a664c5de1f0f1523a) add sample hook script that restarts nginx upon successful cert creation - [`cec4bd6`](https://github.com/dehydrated-io/dehydrated/commit/cec4bd6062632044b832bfb2b35a63297c8ac137) rename sample hook script - [`9e320b0`](https://github.com/dehydrated-io/dehydrated/commit/9e320b08ad2491066b37a2a781b9cb27b0d635d9) rename hook script (again) to comply with the other example files - [`9795668`](https://github.com/dehydrated-io/dehydrated/commit/979566897d0e7935b6b15d5539c7337210fc4419) minor - [`6662209`](https://github.com/dehydrated-io/dehydrated/commit/666220936ca4d7687d5fc8d960960acdd80b2ca0) fix typo in test.sh (ngrok not found) - [`c928a11`](https://github.com/dehydrated-io/dehydrated/commit/c928a11a17fa15676ce3dc34bdf65f5c47be0645) Merge remote-tracking branch 'upstream/master' - [`aa23109`](https://github.com/dehydrated-io/dehydrated/commit/aa2310958876c9ad87255b9a1244e8d250e43c20) Merge branch 'upstream' - [`9439741`](https://github.com/dehydrated-io/dehydrated/commit/94397411b70a50f0f91e2b920969791f4ed25638) Merge branch 'upstream' - [`5aff16b`](https://github.com/dehydrated-io/dehydrated/commit/5aff16b820e6ab18d78807a5bf038870e8faa6b1) Merge remote-tracking branch 'upstream/master' - [`a2a6559`](https://github.com/dehydrated-io/dehydrated/commit/a2a65599f81d1303c275f4e137d098e809783750) changed the way SCRIPTDIR is searched for so it works better with symbolic links (e.g. a symbolic link in ~/.bin) ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `letsencrypt.sh` (+2 -0) </details> ### 📄 Description Cleanup wouldn't work for me, if the config isn't loaded in command_cleanup() --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:28:41 +01:00

adam closed this issue

2025-12-29 01:28:42 +01:00

adam referenced this issue

2025-12-29 01:29:57 +01:00

[PR #728] [CLOSED] Don't assume order status to be valid, retry if needed #910

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#728