starred/crono
1
0
Fork 0
mirror of https://github.com/plashchynski/crono.git synced 2026-01-11 21:10:24 +01:00
Code Issues 35 Packages Projects Releases 9 Wiki Activity

[PR #74] [MERGED] fix: rails 4.0.x #90

New Issue
Closed
opened 2025-12-29 00:22:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 00:22:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/74
Author: @muZk
Created: 4/11/2018
Status: ✅ Merged
Merged: 5/29/2022
Merged by: @plashchynski

Base: master ← Head: patch-1

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 lib/crono/period.rb (+2 -1)

📄 Description

Hash in rails 4.0.x does not have compact method (and in the description it says crono works for rails 4*).

This PR fix the related issue https://github.com/plashchynski/crono/issues/43

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/74 **Author:** [@muZk](https://github.com/muZk) **Created:** 4/11/2018 **Status:** ✅ Merged **Merged:** 5/29/2022 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`11350e8`](https://github.com/plashchynski/crono/commit/11350e83d965fd5d9d62324016434c4e5f1123d1) fix: rails 4.0.x ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/crono/period.rb` (+2 -1) </details> ### 📄 Description Hash in rails 4.0.x does not have `compact` method (and in the description it says crono works for rails 4*). This PR fix the related issue https://github.com/plashchynski/crono/issues/43 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 00:22:31 +01:00
adam closed this issue 2025-12-29 00:22:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/crono#90
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?