[PR #13] [MERGED] Default to not writing a pidfile unless daemonized #74

New Issue

adam · 2025-12-29T00:22:22+01:00

adam commented

2025-12-29 00:22:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/13
Author: @thomasfedb
Created: 4/1/2015
Status: ✅ Merged
Merged: 4/2/2015
Merged by: @plashchynski

Base: master ← Head: daemon-pidfile-default

📝 Commits (1)

4b28f3d Updated CLI and Config to default to not writing a pidfile unless daemonized.

📊 Changes

3 files changed (+33 additions, -2 deletions)

View changed files

📝 lib/crono/cli.rb (+1 -0)
📝 lib/crono/config.rb (+4 -1)
📝 spec/config_spec.rb (+28 -1)

📄 Description

Pidfiles are generally only used when you have a daemonized process. In other circumstances they are superfluous and can actually cause issues (e.g. deploying to Heroku with no tmp directory).

This PR enables pidfiles by default only when daemonized, although the pidfile can always be explicity enabled.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/13 **Author:** [@thomasfedb](https://github.com/thomasfedb) **Created:** 4/1/2015 **Status:** ✅ Merged **Merged:** 4/2/2015 **Merged by:** [@plashchynski](https://github.com/plashchynski) **Base:** `master` ← **Head:** `daemon-pidfile-default` --- ### 📝 Commits (1) - [`4b28f3d`](https://github.com/plashchynski/crono/commit/4b28f3dd80cd81475bd2f2d4e5d2fb83abc1b050) Updated CLI and Config to default to not writing a pidfile unless daemonized. ### 📊 Changes **3 files changed** (+33 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `lib/crono/cli.rb` (+1 -0) 📝 `lib/crono/config.rb` (+4 -1) 📝 `spec/config_spec.rb` (+28 -1) </details> ### 📄 Description Pidfiles are generally only used when you have a daemonized process. In other circumstances they are superfluous and can actually cause issues (e.g. deploying to Heroku with no `tmp` directory). This PR enables pidfiles by default only when daemonized, although the pidfile can always be explicity enabled. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 00:22:22 +01:00

adam closed this issue

2025-12-29 00:22:23 +01:00

adam referenced this issue

2025-12-29 00:22:31 +01:00

[PR #74] [MERGED] fix: rails 4.0.x #90

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/crono#74