starred/crono
1
0
Fork 0
mirror of https://github.com/plashchynski/crono.git synced 2026-01-14 06:13:26 +01:00
Code Issues 35 Packages Projects Releases 9 Wiki Activity

[PR #123] [MERGED] Remove Sprockets hard dependency, allow Propshaft #123

New Issue
Closed
opened 2025-12-29 00:22:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 00:22:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/plashchynski/crono/pull/123
Author: @janko
Created: 12/15/2023
Status: ✅ Merged
Merged: 12/19/2023
Merged by: @cseelus

Base: main ← Head: allow-propshaft

📝 Commits (1)

  • 7dffc5c Remove Sprockets hard dependency, allow Propshaft

📊 Changes

4 files changed (+5 additions, -11 deletions)

View changed files

📝 Gemfile.lock (+0 -8)
📝 crono.gemspec (+0 -1)
📝 lib/crono.rb (+0 -1)
📝 lib/crono/engine.rb (+5 -1)

📄 Description

This removes sprockets-rails from dependencies, allowing usage with Propshaft, which is a significantly lighter asset pipeline (10x less code than Sprockets).

This is a breaking change for people using Crono without having sprockets-rails in their Gemfiles.

Fixes #122

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/plashchynski/crono/pull/123 **Author:** [@janko](https://github.com/janko) **Created:** 12/15/2023 **Status:** ✅ Merged **Merged:** 12/19/2023 **Merged by:** [@cseelus](https://github.com/cseelus) **Base:** `main` ← **Head:** `allow-propshaft` --- ### 📝 Commits (1) - [`7dffc5c`](https://github.com/plashchynski/crono/commit/7dffc5c77b29c1eea5e43726dccc2f82066eecd9) Remove Sprockets hard dependency, allow Propshaft ### 📊 Changes **4 files changed** (+5 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Gemfile.lock` (+0 -8) 📝 `crono.gemspec` (+0 -1) 📝 `lib/crono.rb` (+0 -1) 📝 `lib/crono/engine.rb` (+5 -1) </details> ### 📄 Description This removes `sprockets-rails` from dependencies, allowing usage with Propshaft, which is a significantly lighter asset pipeline (10x less code than Sprockets). This is a breaking change for people using Crono without having `sprockets-rails` in their Gemfiles. Fixes #122 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 00:22:49 +01:00
adam closed this issue 2025-12-29 00:22:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/crono#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?