Add job#log_error, log error with ERROR severity

This commit is contained in:
Dzmitry Plashchynski
2015-03-10 23:59:39 +02:00
parent 46fe2548d9
commit 6d2e3fbb75
2 changed files with 19 additions and 7 deletions

View File

@@ -52,8 +52,8 @@ module Crono
begin
performer.new.perform
rescue Exception => e
log "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at)
log e.backtrace.join("\n")
log_error "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at)
log_error e.backtrace.join("\n")
self.healthy = false
else
self.healthy = true
@@ -63,10 +63,14 @@ module Crono
end
end
def log(message)
def log_error(message)
log(message, Logger::ERROR)
end
def log(message, severity = Logger::INFO)
@semaphore.synchronize do
logger.info message
job_logger.info message
logger.log severity, message
job_logger.log severity, message
end
end

View File

@@ -94,8 +94,8 @@ describe Crono::Job do
describe "#log" do
it "should write log messages to both common and job log" do
message = "Test message"
expect(job.logger).to receive(:info).with(message)
expect(job.job_logger).to receive(:info).with(message)
expect(job.logger).to receive(:log).with(Logger::INFO, message)
expect(job.job_logger).to receive(:log).with(Logger::INFO, message)
job.send(:log, message)
end
@@ -105,4 +105,12 @@ describe Crono::Job do
expect(job.job_log.string).to include(message)
end
end
describe "#log_error" do
it "should call log with ERROR severity" do
message = "Test message"
expect(job).to receive(:log).with(message, Logger::ERROR)
job.send(:log_error, message)
end
end
end