From 6d2e3fbb75bc2f2d72b95ad3d1655c609379920b Mon Sep 17 00:00:00 2001 From: Dzmitry Plashchynski Date: Tue, 10 Mar 2015 23:59:39 +0200 Subject: [PATCH] Add job#log_error, log error with ERROR severity --- lib/crono/job.rb | 14 +++++++++----- spec/job_spec.rb | 12 ++++++++++-- 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/lib/crono/job.rb b/lib/crono/job.rb index 10a8ab4..c6ff55a 100644 --- a/lib/crono/job.rb +++ b/lib/crono/job.rb @@ -52,8 +52,8 @@ module Crono begin performer.new.perform rescue Exception => e - log "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at) - log e.backtrace.join("\n") + log_error "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at) + log_error e.backtrace.join("\n") self.healthy = false else self.healthy = true @@ -63,10 +63,14 @@ module Crono end end - def log(message) + def log_error(message) + log(message, Logger::ERROR) + end + + def log(message, severity = Logger::INFO) @semaphore.synchronize do - logger.info message - job_logger.info message + logger.log severity, message + job_logger.log severity, message end end diff --git a/spec/job_spec.rb b/spec/job_spec.rb index 2953d79..b5fce77 100644 --- a/spec/job_spec.rb +++ b/spec/job_spec.rb @@ -94,8 +94,8 @@ describe Crono::Job do describe "#log" do it "should write log messages to both common and job log" do message = "Test message" - expect(job.logger).to receive(:info).with(message) - expect(job.job_logger).to receive(:info).with(message) + expect(job.logger).to receive(:log).with(Logger::INFO, message) + expect(job.job_logger).to receive(:log).with(Logger::INFO, message) job.send(:log, message) end @@ -105,4 +105,12 @@ describe Crono::Job do expect(job.job_log.string).to include(message) end end + + describe "#log_error" do + it "should call log with ERROR severity" do + message = "Test message" + expect(job).to receive(:log).with(message, Logger::ERROR) + job.send(:log_error, message) + end + end end