mirror of
https://github.com/plashchynski/crono.git
synced 2026-06-12 01:34:25 +02:00
Add job#log_error, log error with ERROR severity
This commit is contained in:
+9
-5
@@ -52,8 +52,8 @@ module Crono
|
|||||||
begin
|
begin
|
||||||
performer.new.perform
|
performer.new.perform
|
||||||
rescue Exception => e
|
rescue Exception => e
|
||||||
log "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at)
|
log_error "Finished #{performer} in %.2f seconds with error: #{e.message}" % (Time.now - last_performed_at)
|
||||||
log e.backtrace.join("\n")
|
log_error e.backtrace.join("\n")
|
||||||
self.healthy = false
|
self.healthy = false
|
||||||
else
|
else
|
||||||
self.healthy = true
|
self.healthy = true
|
||||||
@@ -63,10 +63,14 @@ module Crono
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def log(message)
|
def log_error(message)
|
||||||
|
log(message, Logger::ERROR)
|
||||||
|
end
|
||||||
|
|
||||||
|
def log(message, severity = Logger::INFO)
|
||||||
@semaphore.synchronize do
|
@semaphore.synchronize do
|
||||||
logger.info message
|
logger.log severity, message
|
||||||
job_logger.info message
|
job_logger.log severity, message
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
+10
-2
@@ -94,8 +94,8 @@ describe Crono::Job do
|
|||||||
describe "#log" do
|
describe "#log" do
|
||||||
it "should write log messages to both common and job log" do
|
it "should write log messages to both common and job log" do
|
||||||
message = "Test message"
|
message = "Test message"
|
||||||
expect(job.logger).to receive(:info).with(message)
|
expect(job.logger).to receive(:log).with(Logger::INFO, message)
|
||||||
expect(job.job_logger).to receive(:info).with(message)
|
expect(job.job_logger).to receive(:log).with(Logger::INFO, message)
|
||||||
job.send(:log, message)
|
job.send(:log, message)
|
||||||
end
|
end
|
||||||
|
|
||||||
@@ -105,4 +105,12 @@ describe Crono::Job do
|
|||||||
expect(job.job_log.string).to include(message)
|
expect(job.job_log.string).to include(message)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe "#log_error" do
|
||||||
|
it "should call log with ERROR severity" do
|
||||||
|
message = "Test message"
|
||||||
|
expect(job).to receive(:log).with(message, Logger::ERROR)
|
||||||
|
job.send(:log_error, message)
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Reference in New Issue
Block a user