starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4608] [MERGED] Remove token from hls url #4299

New Issue
Closed
opened 2026-04-25 00:19:11 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:11 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4608
Author: @laxandrea
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @advplyr

Base: master ← Head: remove-token-from-hls-url

📝 Commits (1)

  • 2cc6e56 remove token from hls url

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 server/objects/Stream.js (+1 -1)
📝 server/utils/generators/hlsPlaylistGenerator.js (+5 -5)

📄 Description

Brief summary

PR #4266 removed authorization for hls streams so there is no need to add the token to the url of the audio chucks

Which issue is fixed?

Following PR #4263

In-depth Description

Showing the token in the URL could be unsafe in some situations

How have you tested this?

Browser with custom client

Screenshots

Screenshot 2025-08-19 at 15 44 06 Screenshot 2025-08-19 at 15 46 02

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4608 **Author:** [@laxandrea](https://github.com/laxandrea) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `remove-token-from-hls-url` --- ### 📝 Commits (1) - [`2cc6e56`](https://github.com/advplyr/audiobookshelf/commit/2cc6e56bd15f0820aa2f2b266ef8dcaf75a93cd2) remove token from hls url ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/objects/Stream.js` (+1 -1) 📝 `server/utils/generators/hlsPlaylistGenerator.js` (+5 -5) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary PR #4266 removed authorization for hls streams so there is no need to add the token to the url of the audio chucks ## Which issue is fixed? Following PR #4263 ## In-depth Description Showing the token in the URL could be unsafe in some situations ## How have you tested this? Browser with custom client ## Screenshots <img width="293" height="84" alt="Screenshot 2025-08-19 at 15 44 06" src="https://github.com/user-attachments/assets/a7dc7790-aabb-4605-851e-e44ee30387f2" /> <img width="327" height="153" alt="Screenshot 2025-08-19 at 15 46 02" src="https://github.com/user-attachments/assets/e729e4e1-3778-4db4-96af-79869da8e7e6" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:11 +02:00
adam closed this issue 2026-04-25 00:19:11 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4299
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?