starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4486] [MERGED] Fix OIDC auto register user #4485 #4263

New Issue
Closed
opened 2026-04-25 00:19:03 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:03 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4486
Author: @advplyr
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @advplyr

Base: master ← Head: fix_oidc_create_user

📝 Commits (1)

📊 Changes

3 files changed (+21 additions, -9 deletions)

View changed files

📝 server/auth/OidcAuthStrategy.js (+1 -1)
📝 server/auth/TokenManager.js (+13 -1)
📝 server/models/User.js (+7 -7)

📄 Description

Brief summary

The OIDC auth refactor caused the generate access token function to be unavailable when auto registering a user.

This adds a static generate token function.

When the old auth method gets removed this won't be necessary and those functions will be removed.

Which issue is fixed?

Fixes #4485

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4486 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix_oidc_create_user` --- ### 📝 Commits (1) - [`f7b94a4`](https://github.com/advplyr/audiobookshelf/commit/f7b94a4b6d9fb37ef9e8e8a807ee1e75452db44c) Fix OIDC auto register user #4485 ### 📊 Changes **3 files changed** (+21 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `server/auth/OidcAuthStrategy.js` (+1 -1) 📝 `server/auth/TokenManager.js` (+13 -1) 📝 `server/models/User.js` (+7 -7) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary The OIDC auth refactor caused the generate access token function to be unavailable when auto registering a user. This adds a static generate token function. When the old auth method gets removed this won't be necessary and those functions will be removed. ## Which issue is fixed? Fixes #4485 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:03 +02:00
adam closed this issue 2026-04-25 00:19:03 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?