starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4413] [MERGED] Make NUSQLITE3_PATH build arg configurable #4243

New Issue
Closed
opened 2026-04-25 00:18:58 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:58 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4413
Author: @HadrienPatte
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @advplyr

Base: master ← Head: nusqlite3-path

📝 Commits (1)

  • ba4061e Make NUSQLITE3_PATH build arg configurable

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Dockerfile (+1 -1)

📄 Description

Brief summary

Make NUSQLITE3_PATH build arg configurable

Which issue is fixed?

None

In-depth Description

The dockerfile currently exposes two build args (NUSQLITE3_DIR and NUSQLITE3_PATH) to configure the location of the nunicode-sqlite library, but one COPY instruction from that dockerfile hardcodes the default value of that arg, leading any build with a custom value of that arg to fail.

How have you tested this?

Before:
docker build --build-arg NUSQLITE3_DIR=/something . fails with:

 => ERROR [stage-2 6/6] COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3                                                                                 0.0s 
------                                                                                                                                                                                  
 > [stage-2 6/6] COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3:                                                                                            
------                                                                                                                                                                                  
Dockerfile:60                                                                                                                                                                           
--------------------
  58 |     COPY --from=build-client /client/dist /app/client/dist
  59 |     COPY --from=build-server /server /app
  60 | >>> COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3
  61 |     
  62 |     EXPOSE 80
--------------------
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref C7EG:K5UQ:XJBR:E73C:GPFP:XRKP:5MHC:MR66:I3CH:5QUB:3T6N:3T5Z::bwnen464mqy9zqt5ucrcetcsq: "/usr/local/lib/nusqlite3": not found

After:
The same command successfully builds a working image.

Screenshots

Does not apply

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4413 **Author:** [@HadrienPatte](https://github.com/HadrienPatte) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `nusqlite3-path` --- ### 📝 Commits (1) - [`ba4061e`](https://github.com/advplyr/audiobookshelf/commit/ba4061e5a406c03bffe178232a0a5f7172649ceb) Make `NUSQLITE3_PATH` build arg configurable ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Make `NUSQLITE3_PATH` build arg configurable ## Which issue is fixed? None ## In-depth Description The dockerfile currently exposes two build args (`NUSQLITE3_DIR` and `NUSQLITE3_PATH`) to configure the location of the nunicode-sqlite library, but one COPY instruction from that dockerfile hardcodes the default value of that arg, leading any build with a custom value of that arg to fail. <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? Before: `docker build --build-arg NUSQLITE3_DIR=/something .` fails with: ``` => ERROR [stage-2 6/6] COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3 0.0s ------ > [stage-2 6/6] COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3: ------ Dockerfile:60 -------------------- 58 | COPY --from=build-client /client/dist /app/client/dist 59 | COPY --from=build-server /server /app 60 | >>> COPY --from=build-server /usr/local/lib/nusqlite3 /usr/local/lib/nusqlite3 61 | 62 | EXPOSE 80 -------------------- ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref C7EG:K5UQ:XJBR:E73C:GPFP:XRKP:5MHC:MR66:I3CH:5QUB:3T6N:3T5Z::bwnen464mqy9zqt5ucrcetcsq: "/usr/local/lib/nusqlite3": not found ``` After: The same command successfully builds a working image. ## Screenshots Does not apply --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:58 +02:00
adam closed this issue 2026-04-25 00:18:58 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?