starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5076] AuthorController: Update author name in match if changed #4413

New Issue
Open
opened 2026-04-25 00:19:39 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:39 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5076
Author: @mikiher
Created: 2/21/2026
Status: 🔄 Open

Base: master ← Head: author-match-fix

📝 Commits (1)

  • 45e1b25 AuthorController: Update author name in match if changed

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 server/controllers/AuthorController.js (+5 -0)

📄 Description

Brief summary

When quick matching an author, a check is added if the matched author name is different from the saved author.

Which issue is fixed?

Fixes #5075

The author name check was missing and therefore the author name was not updated as expected.
I added a diff check similar to other fields, and if there's a diff, it updates the author name and sets hasUpdates appropriately.

How have you tested this?

Ran the repro steps in the bug. Now the expected update happens.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5076 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 2/21/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `author-match-fix` --- ### 📝 Commits (1) - [`45e1b25`](https://github.com/advplyr/audiobookshelf/commit/45e1b25ea3a1a85f18cea88f2d013900c4f53725) AuthorController: Update author name in match if changed ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/AuthorController.js` (+5 -0) </details> ### 📄 Description ## Brief summary When quick matching an author, a check is added if the matched author name is different from the saved author. ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> Fixes #5075 The author name check was missing and therefore the author name was not updated as expected. I added a diff check similar to other fields, and if there's a diff, it updates the author name and sets `hasUpdates` appropriately. ## How have you tested this? Ran the repro steps in the bug. Now the expected update happens. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:39 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?