starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4241] [MERGED] Fix player track tooltip overflowing on share player #4196

New Issue
Closed
opened 2026-04-25 00:18:44 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:44 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4241
Author: @advplyr
Created: 4/30/2025
Status: ✅ Merged
Merged: 4/30/2025
Merged by: @advplyr

Base: master ← Head: player_track_tooltip

📝 Commits (1)

  • 6819c0b Fix player track tooltip overflowing on share player

📊 Changes

2 files changed (+13 additions, -3 deletions)

View changed files

📝 client/components/player/PlayerTrackBar.vue (+7 -0)
📝 client/pages/share/_slug.vue (+6 -3)

📄 Description

Brief summary

Share audio player track bar tooltip overflows the page causing a horizontal scroll bar.

Which issue is fixed?

No issue

In-depth Description

The track bar padding in the share player is larger than the regular player so the tooltip calculation was off.

This also disables the tooltip on mobile for both the share player and regular player. The tooltip should only be shown when hovering with the mouse.

How have you tested this?

Screenshots

Overflow
image

Fixed
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4241 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 4/30/2025 **Status:** ✅ Merged **Merged:** 4/30/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `player_track_tooltip` --- ### 📝 Commits (1) - [`6819c0b`](https://github.com/advplyr/audiobookshelf/commit/6819c0b108c1830abbb590631b12fdf9d4e34c07) Fix player track tooltip overflowing on share player ### 📊 Changes **2 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/components/player/PlayerTrackBar.vue` (+7 -0) 📝 `client/pages/share/_slug.vue` (+6 -3) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Share audio player track bar tooltip overflows the page causing a horizontal scroll bar. ## Which issue is fixed? No issue ## In-depth Description The track bar padding in the share player is larger than the regular player so the tooltip calculation was off. This also disables the tooltip on mobile for both the share player and regular player. The tooltip should only be shown when hovering with the mouse. ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots Overflow ![image](https://github.com/user-attachments/assets/8361491d-2c17-4dda-a30c-dd1915c6bb9d) Fixed ![image](https://github.com/user-attachments/assets/e03c3e3c-b8df-42b1-8abc-3e96b68078ce) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:44 +02:00
adam closed this issue 2026-04-25 00:18:44 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4196
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?