starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4214] [CLOSED] Merge files without encoding #4190

New Issue
Closed
opened 2026-04-25 00:18:42 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:42 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4214
Author: @Vito0912
Created: 4/20/2025
Status: ❌ Closed

Base: master ← Head: feat/onlyMerge

📝 Commits (1)

  • cd711b0 implement Merge files without encoding

📊 Changes

2 files changed (+14 additions, -5 deletions)

View changed files

📝 client/pages/audiobook/_id/manage.vue (+13 -5)
📝 client/strings/en-us.json (+1 -0)

📄 Description

Brief summary

If more than one file is available, show an extra option that automatically sets encoding to copy in order to merge the files, thereby disabling advanced options.

Also fixes a visual bug where, if a user cancels a task, the advanced button still appears clickable even though it is not actually clickable.

This time I applied Prettier, but it did nothing (because it's a Vue file). When I used the official formatter for Vue.js, it even changed lines I did not edit. So, I guess this is not desired. If I should apply a formatter, please leave a comment.

Which issue is fixed?

#4169

In-depth Description

N/A. See above

How have you tested this?

Merging a few books

Screenshots

grafik

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4214 **Author:** [@Vito0912](https://github.com/Vito0912) **Created:** 4/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat/onlyMerge` --- ### 📝 Commits (1) - [`cd711b0`](https://github.com/advplyr/audiobookshelf/commit/cd711b021b472a01aede9a35143366bf64e276be) implement Merge files without encoding ### 📊 Changes **2 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/manage.vue` (+13 -5) 📝 `client/strings/en-us.json` (+1 -0) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary <!-- Please provide a brief summary of what your PR attempts to achieve. --> If more than one file is available, show an extra option that automatically sets encoding to copy in order to merge the files, thereby disabling advanced options. Also fixes a visual bug where, if a user cancels a task, the advanced button still appears clickable even though it is not actually clickable. --- This time I applied Prettier, but it did nothing (because it's a Vue file). When I used the official formatter for Vue.js, it even changed lines I did not edit. So, I guess this is not desired. If I should apply a formatter, please leave a comment. ## Which issue is fixed? #4169 ## In-depth Description N/A. See above ## How have you tested this? Merging a few books ## Screenshots ![grafik](https://github.com/user-attachments/assets/dac9a84f-178d-4533-92aa-1ef0ed26e165) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:42 +02:00
adam closed this issue 2026-04-25 00:18:42 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?