starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4100] [CLOSED] Use multiplication symbol instead of letter x #4169

New Issue
Closed
opened 2026-04-25 00:18:38 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:38 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4100
Author: @majjejjam
Created: 3/11/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

  • f7f80e0 Use multiplication symbol instead of letter x

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 client/components/controls/PlaybackSpeedControl.vue (+3 -3)

📄 Description

Brief summary

Use the proper multiplication symbol (×) for the playback speed.

Which issue is fixed?

Minor polish.

In-depth Description

In the playback speed popup, the letter "x" is switched out for the multiplication symbol "×". The order of the number and symbol is reversed so it is read "times 1.0" instead of "1.0 times" (or previously "1.0 x"). Between the symbol and the number, a narrow no-break space ( ) is added for proper spacing. The classes of some spans are removed for better alignment.

How have you tested this?

I have generated the client and ran the server to make sure the changes had no unintended side effects. The playback speed controls still work as usual.

Screenshots

Before After
bild Skärmbild från 2025-03-11 12-56-13

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4100 **Author:** [@majjejjam](https://github.com/majjejjam) **Created:** 3/11/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`f7f80e0`](https://github.com/advplyr/audiobookshelf/commit/f7f80e03e0fbfbb5ca482e3de7ff3a4da0305ad3) Use multiplication symbol instead of letter x ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/components/controls/PlaybackSpeedControl.vue` (+3 -3) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Use the proper multiplication symbol (×) for the playback speed. <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? Minor polish. <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description In the playback speed popup, the letter "x" is switched out for the multiplication symbol "×". The order of the number and symbol is reversed so it is read "times 1.0" instead of "1.0 times" (or previously "1.0 x"). Between the symbol and the number, a narrow no-break space (`&#8239;`) is added for proper spacing. The classes of some spans are removed for better alignment. <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? I have generated the client and ran the server to make sure the changes had no unintended side effects. The playback speed controls still work as usual. <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots | Before | After | | --- | --- | | ![bild](https://github.com/user-attachments/assets/63852d87-5b3d-422e-93f0-53de4dc9ccc1) | ![Skärmbild från 2025-03-11 12-56-13](https://github.com/user-attachments/assets/2e4c6a79-92a0-415e-972c-6718944b3858) | <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:38 +02:00
adam closed this issue 2026-04-25 00:18:38 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?