starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4213] [MERGED] Chapter lookup error interface update #4188

New Issue
Closed
opened 2026-04-25 00:18:42 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:42 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4213
Author: @nichwall
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/26/2025
Merged by: @advplyr

Base: master ← Head: chapter_lookup_error_fix

📝 Commits (2)

  • 7e69713 Change: chapter lookup to be in modal
  • 79fe064 Add: server localization for chapter lookup

📊 Changes

3 files changed (+23 additions, -8 deletions)

View changed files

📝 client/pages/audiobook/_id/chapters.vue (+18 -6)
📝 client/strings/en-us.json (+3 -0)
📝 server/controllers/SearchController.js (+2 -2)

📄 Description

Brief summary

This PR provides more information when a chapter lookup fails. Instead of closing the modal and showing a toast message, the error is displayed in the modal with some extra information.

Which issue is fixed?

Addresses https://github.com/advplyr/audiobookshelf/issues/4210 (the issue is already closed, but is representative of a FAQ/common issue)

In-depth Description

An additional string is added to ensure users are using the ASIN from Audible instead of Amazon because they look the same to a user.

I also localized the "chapter lookup error" from the server by adding a string key to the server response. I left the current error string in case anybody is using it (I doubt it, but just in case).

How have you tested this?

Tested with valid ASIN, invalid ASIN, and ASIN from Amazon/wrong region.

Screenshots

I am not in love with the layout, but this was the best I could come up with. The extra space on the top looks weird, but I also prefer the inputs not moving when the messages appear.
Screenshot from 2025-04-19 23-25-25
Screenshot from 2025-04-19 23-25-31
Screenshot from 2025-04-19 23-25-46

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4213 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/26/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `chapter_lookup_error_fix` --- ### 📝 Commits (2) - [`7e69713`](https://github.com/advplyr/audiobookshelf/commit/7e69713683cd4b449bdb3a94ee7ab5649c64b1cf) Change: chapter lookup to be in modal - [`79fe064`](https://github.com/advplyr/audiobookshelf/commit/79fe064c4a313d11d95f2b4ff70af15949cce21c) Add: server localization for chapter lookup ### 📊 Changes **3 files changed** (+23 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/chapters.vue` (+18 -6) 📝 `client/strings/en-us.json` (+3 -0) 📝 `server/controllers/SearchController.js` (+2 -2) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This PR provides more information when a chapter lookup fails. Instead of closing the modal and showing a toast message, the error is displayed in the modal with some extra information. ## Which issue is fixed? Addresses https://github.com/advplyr/audiobookshelf/issues/4210 (the issue is already closed, but is representative of a FAQ/common issue) ## In-depth Description An additional string is added to ensure users are using the ASIN from Audible instead of Amazon because they look the same to a user. I also localized the "chapter lookup error" from the server by adding a string key to the server response. I left the current error string in case anybody is using it (I doubt it, but just in case). ## How have you tested this? Tested with valid ASIN, invalid ASIN, and ASIN from Amazon/wrong region. ## Screenshots I am not in love with the layout, but this was the best I could come up with. The extra space on the top looks weird, but I also prefer the inputs not moving when the messages appear. ![Screenshot from 2025-04-19 23-25-25](https://github.com/user-attachments/assets/6368b4d4-04b6-4451-8ea2-131df82bff37) ![Screenshot from 2025-04-19 23-25-31](https://github.com/user-attachments/assets/52a7b1f6-7c19-4988-85b9-27ed21ff960e) ![Screenshot from 2025-04-19 23-25-46](https://github.com/user-attachments/assets/122be930-c36b-4a1e-9bdc-3732fa3671fd) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:42 +02:00
adam closed this issue 2026-04-25 00:18:42 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4188
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?