starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4318] [MERGED] Update max allowed json request size #4250 #4213

New Issue
Closed
opened 2026-04-25 00:18:50 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:50 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4318
Author: @advplyr
Created: 5/21/2025
Status: ✅ Merged
Merged: 5/21/2025
Merged by: @advplyr

Base: master ← Head: increase_express_json_limit

📝 Commits (1)

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 client/components/modals/podcast/EpisodeFeed.vue (+2 -2)
📝 server/Server.js (+1 -1)

📄 Description

Brief summary

This increases the limit of express.json from 5mb to 10mb.
And updates the check when downloading episodes that prevents too large of requests.

Which issue is fixed?

Fixes #4250

In-depth Description

Increasing the limit allows for downloading more episodes in a single request. This is the only place in the app where JSON requests of that size are sent. We could break up the request into multiple and keep them under 5mb, but having a 10mb limit seemed reasonable.

How have you tested this?

Example RSS feed: https://feeds.simplecast.com/54nAGcIl

When adding this podcast and selecting all episodes to download at once, the request size is around 9.7mb. This is now supported.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4318 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 5/21/2025 **Status:** ✅ Merged **Merged:** 5/21/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `increase_express_json_limit` --- ### 📝 Commits (1) - [`cae874e`](https://github.com/advplyr/audiobookshelf/commit/cae874ef0577acbd2bdf4dc02f601caaaadebddf) Update max allowed json request size #4250 ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/podcast/EpisodeFeed.vue` (+2 -2) 📝 `server/Server.js` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary This increases the limit of [express.json](https://expressjs.com/en/api.html#express.json) from 5mb to 10mb. And updates the check when downloading episodes that prevents too large of requests. ## Which issue is fixed? Fixes #4250 ## In-depth Description Increasing the limit allows for downloading more episodes in a single request. This is the only place in the app where JSON requests of that size are sent. We could break up the request into multiple and keep them under 5mb, but having a 10mb limit seemed reasonable. ## How have you tested this? Example RSS feed: https://feeds.simplecast.com/54nAGcIl When adding this podcast and selecting all episodes to download at once, the request size is around 9.7mb. This is now supported. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:50 +02:00
adam closed this issue 2026-04-25 00:18:50 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?