starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3958] [MERGED] Fix ROUTER_BASE_PATH override for empty string #4132

New Issue
Closed
opened 2026-04-25 00:18:26 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:26 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3958
Author: @devnoname120
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @advplyr

Base: master ← Head: fix-apex-path-support

📝 Commits (1)

  • 14e9243 Fix ROUTER_BASE_PATH override for empty string

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 client/nuxt.config.js (+1 -1)
📝 index.js (+2 -2)
📝 prod.js (+1 -1)

📄 Description

Brief summary

When the ROUTER_BASE_PATH env variable is set to an empty string it's mistakenly overriden to /audiobookshelf instead.
The /audiobookshelf fallback should only be used when the ROUTER_BASE_PATH env variable is undefined, not just an empty string.

Regression introduced in https://github.com/advplyr/audiobookshelf/pull/3810
See also: https://github.com/advplyr/audiobookshelf/pull/3810#discussion_r1948790937

Which issue is fixed?

Related: https://github.com/advplyr/audiobookshelf/issues/3874 (requires frontend recompilation to fix that one)

How have you tested this?

Running the following before starting Audiobookshelf:

export ROUTER_BASE_PATH=''

Screenshots

N/A

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3958 **Author:** [@devnoname120](https://github.com/devnoname120) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-apex-path-support` --- ### 📝 Commits (1) - [`14e9243`](https://github.com/advplyr/audiobookshelf/commit/14e92435ec95eaab2546666db41b59e70e548d53) Fix `ROUTER_BASE_PATH` override for empty string ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `client/nuxt.config.js` (+1 -1) 📝 `index.js` (+2 -2) 📝 `prod.js` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary When the `ROUTER_BASE_PATH` env variable is set to an empty string it's mistakenly overriden to `/audiobookshelf` instead. The `/audiobookshelf` fallback should only be used when the `ROUTER_BASE_PATH` env variable is undefined, not just an empty string. Regression introduced in https://github.com/advplyr/audiobookshelf/pull/3810 See also: https://github.com/advplyr/audiobookshelf/pull/3810#discussion_r1948790937 ## Which issue is fixed? Related: https://github.com/advplyr/audiobookshelf/issues/3874 (requires frontend recompilation to fix that one) ## How have you tested this? Running the following before starting Audiobookshelf: ```shell export ROUTER_BASE_PATH='' ``` ## Screenshots N/A --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:26 +02:00
adam closed this issue 2026-04-25 00:18:26 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?