starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3396] [MERGED] Add a try-catch block around custom provider search #3958

New Issue
Closed
opened 2026-04-25 00:17:43 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:43 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3396
Author: @mikiher
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @advplyr

Base: master ← Head: custom-provider-try-catch

📝 Commits (1)

  • 80685af Add a try-catch block around custom provider search

📊 Changes

1 file changed (+8 additions, -4 deletions)

View changed files

📝 server/finders/BookFinder.js (+8 -4)

📄 Description

This fixes #3390.

CustomProviderAdapter.search has the potential to throw errors that weren't caught by the caller.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3396 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `custom-provider-try-catch` --- ### 📝 Commits (1) - [`80685af`](https://github.com/advplyr/audiobookshelf/commit/80685afa7e5665543a0d41d464400bbc51c9aa82) Add a try-catch block around custom provider search ### 📊 Changes **1 file changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/finders/BookFinder.js` (+8 -4) </details> ### 📄 Description This fixes #3390. CustomProviderAdapter.search has the potential to throw errors that weren't caught by the caller. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:43 +02:00
adam closed this issue 2026-04-25 00:17:43 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?