starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3491] [MERGED] retire unicode handling workaround for Author and Series title #3990

New Issue
Closed
opened 2026-04-25 00:17:51 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:51 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3491
Author: @thatguy7
Created: 10/8/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @advplyr

Base: master ← Head: unicode-author-series

📝 Commits (2)

  • e6db149 retire unicode handling workaround for Author and Series title
  • 0adceaa Remove asciiOnlyToLowerCase

📊 Changes

4 files changed (+3 additions, -29 deletions)

View changed files

📝 server/controllers/LibraryController.js (+1 -2)
📝 server/models/Author.js (+1 -2)
📝 server/models/Series.js (+1 -2)
📝 server/utils/index.js (+0 -23)

📄 Description

PR https://github.com/advplyr/audiobookshelf/pull/3414 introduced a temporary fix for issue https://github.com/advplyr/audiobookshelf/issues/2541.

Due to https://github.com/advplyr/audiobookshelf/pull/3468 the woraround became absolete and now causes the issue it fixed.

This PR retires the changes introduced in the temporary fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3491 **Author:** [@thatguy7](https://github.com/thatguy7) **Created:** 10/8/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `unicode-author-series` --- ### 📝 Commits (2) - [`e6db149`](https://github.com/advplyr/audiobookshelf/commit/e6db1495abcee8203befbddc4bb49f6892645530) retire unicode handling workaround for Author and Series title - [`0adceaa`](https://github.com/advplyr/audiobookshelf/commit/0adceaa3f0652eb589e6d86bd4d6977aef233ea9) Remove asciiOnlyToLowerCase ### 📊 Changes **4 files changed** (+3 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/LibraryController.js` (+1 -2) 📝 `server/models/Author.js` (+1 -2) 📝 `server/models/Series.js` (+1 -2) 📝 `server/utils/index.js` (+0 -23) </details> ### 📄 Description PR https://github.com/advplyr/audiobookshelf/pull/3414 introduced a temporary fix for issue https://github.com/advplyr/audiobookshelf/issues/2541. Due to https://github.com/advplyr/audiobookshelf/pull/3468 the woraround became absolete and now causes the issue it fixed. This PR retires the changes introduced in the temporary fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:51 +02:00
adam closed this issue 2026-04-25 00:17:51 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?