starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1231] [MERGED] Server respond with objects #3491

New Issue
Closed
opened 2026-04-25 00:15:52 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:52 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1231
Author: @k9withabone
Created: 11/29/2022
Status: ✅ Merged
Merged: 12/13/2022
Merged by: @advplyr

Base: master ← Head: server/respond-with-objects

📝 Commits (10+)

  • cd37a76 Update LibraryController.js to respond with objects
  • b84882d Update LibraryItemController.js to respond with objects
  • 0851050 Update UserController.js to respond with objects
  • b8f74e1 Update CollectionController.js to respond with objects
  • e04d263 Update FileSystemController.js to respond with objects
  • e80c3a1 Update AuthorController.js to respond with objects
  • 3fb2bd3 Update SeriesController.js to respond with objects
  • 13532cb Update SearchController.js to respond with objects
  • c9ab2a2 Update MiscController.js to respond with objects
  • 6b654d3 Update:Starting session for finished item sets the user start time back to 0

📊 Changes

20 files changed (+127 additions, -89 deletions)

View changed files

📝 client/components/app/Appbar.vue (+10 -7)
📝 client/components/modals/AccountModal.vue (+2 -2)
📝 client/components/modals/item/tabs/Cover.vue (+8 -5)
📝 client/components/modals/item/tabs/Match.vue (+3 -3)
📝 client/components/tables/UsersTable.vue (+2 -2)
📝 client/components/tables/library/LibrariesTable.vue (+3 -3)
📝 client/pages/batch/index.vue (+8 -5)
📝 client/pages/config/sessions.vue (+3 -3)
📝 client/pages/library/_library/authors/index.vue (+7 -4)
📝 client/store/libraries.js (+3 -3)
📝 server/controllers/AuthorController.js (+3 -1)
📝 server/controllers/CollectionController.js (+3 -2)
📝 server/controllers/FileSystemController.js (+3 -2)
📝 server/controllers/LibraryController.js (+9 -4)
📝 server/controllers/LibraryItemController.js (+5 -3)
📝 server/controllers/MiscController.js (+3 -1)
📝 server/controllers/SearchController.js (+18 -16)
📝 server/controllers/SeriesController.js (+3 -1)
📝 server/controllers/UserController.js (+3 -1)
📝 server/managers/PlaybackSessionManager.js (+28 -21)

📄 Description

As discussed on matrix, this updates the server so that it always responds with an object, never an array. This simplifies processing the response for clients in other languages. I didn't actually test the changes so that probably should be done before merging.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1231 **Author:** [@k9withabone](https://github.com/k9withabone) **Created:** 11/29/2022 **Status:** ✅ Merged **Merged:** 12/13/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `server/respond-with-objects` --- ### 📝 Commits (10+) - [`cd37a76`](https://github.com/advplyr/audiobookshelf/commit/cd37a7618e7312e73b0d85d86e4ed271f69a181f) Update LibraryController.js to respond with objects - [`b84882d`](https://github.com/advplyr/audiobookshelf/commit/b84882d9d13f33f4818da88adf95e3bc600eacc4) Update LibraryItemController.js to respond with objects - [`0851050`](https://github.com/advplyr/audiobookshelf/commit/08510503920a375754df4478163967be804ab48c) Update UserController.js to respond with objects - [`b8f74e1`](https://github.com/advplyr/audiobookshelf/commit/b8f74e1c98258e0e76ed0a80e967f28edde156ed) Update CollectionController.js to respond with objects - [`e04d263`](https://github.com/advplyr/audiobookshelf/commit/e04d26307e655cdfd37871e1221e3a472b9e5c98) Update FileSystemController.js to respond with objects - [`e80c3a1`](https://github.com/advplyr/audiobookshelf/commit/e80c3a1c5a8a34350c8ab262ff64bbf5d81d0b12) Update AuthorController.js to respond with objects - [`3fb2bd3`](https://github.com/advplyr/audiobookshelf/commit/3fb2bd336207fb4389327cf74f077b6126fc2232) Update SeriesController.js to respond with objects - [`13532cb`](https://github.com/advplyr/audiobookshelf/commit/13532cba1457f6435575351408a1c759c0e7d951) Update SearchController.js to respond with objects - [`c9ab2a2`](https://github.com/advplyr/audiobookshelf/commit/c9ab2a242da43df550135c53a45b8001c97d7034) Update MiscController.js to respond with objects - [`6b654d3`](https://github.com/advplyr/audiobookshelf/commit/6b654d3c2de1762e49ccb63a718363667de5b216) Update:Starting session for finished item sets the user start time back to 0 ### 📊 Changes **20 files changed** (+127 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `client/components/app/Appbar.vue` (+10 -7) 📝 `client/components/modals/AccountModal.vue` (+2 -2) 📝 `client/components/modals/item/tabs/Cover.vue` (+8 -5) 📝 `client/components/modals/item/tabs/Match.vue` (+3 -3) 📝 `client/components/tables/UsersTable.vue` (+2 -2) 📝 `client/components/tables/library/LibrariesTable.vue` (+3 -3) 📝 `client/pages/batch/index.vue` (+8 -5) 📝 `client/pages/config/sessions.vue` (+3 -3) 📝 `client/pages/library/_library/authors/index.vue` (+7 -4) 📝 `client/store/libraries.js` (+3 -3) 📝 `server/controllers/AuthorController.js` (+3 -1) 📝 `server/controllers/CollectionController.js` (+3 -2) 📝 `server/controllers/FileSystemController.js` (+3 -2) 📝 `server/controllers/LibraryController.js` (+9 -4) 📝 `server/controllers/LibraryItemController.js` (+5 -3) 📝 `server/controllers/MiscController.js` (+3 -1) 📝 `server/controllers/SearchController.js` (+18 -16) 📝 `server/controllers/SeriesController.js` (+3 -1) 📝 `server/controllers/UserController.js` (+3 -1) 📝 `server/managers/PlaybackSessionManager.js` (+28 -21) </details> ### 📄 Description As discussed on matrix, this updates the server so that it always responds with an object, never an array. This simplifies processing the response for clients in other languages. I didn't actually test the changes so that probably should be done before merging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:52 +02:00
adam closed this issue 2026-04-25 00:15:52 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3491
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?