starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3354] [CLOSED] Fix libraryFolder not existing on new libraryModel #3946

New Issue
Closed
opened 2026-04-25 00:17:40 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:40 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3354
Author: @nichwall
Created: 9/1/2024
Status: ❌ Closed

Base: master ← Head: libraryFolder_new_model

📝 Commits (3)

  • da82e21 Fix: libraryFolder does not exist for new library model
  • 184858e Ensure folder exists in library
  • 3233017 Fix comment for upload

📊 Changes

2 files changed (+6 additions, -4 deletions)

View changed files

📝 server/controllers/MiscController.js (+3 -2)
📝 server/controllers/PodcastController.js (+3 -2)

📄 Description

Fixes https://github.com/advplyr/audiobookshelf/issues/3353, or at least the cause of two crashes I was able to identify in that issue. I am not sure if there are other places where a similar problem occurs.

This PR uses the libraryFolders table to ensure the folder exists. This was just my attempt at a quick fix, so no worries if there's a better/easier way to resolve the issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3354 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 9/1/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `libraryFolder_new_model` --- ### 📝 Commits (3) - [`da82e21`](https://github.com/advplyr/audiobookshelf/commit/da82e2117b306e28a84947311c23e49488e3f5ef) Fix: `libraryFolder` does not exist for new library model - [`184858e`](https://github.com/advplyr/audiobookshelf/commit/184858efaec9593376168e6527157af0664cf957) Ensure folder exists in library - [`3233017`](https://github.com/advplyr/audiobookshelf/commit/32330177592cda9dd999f9601bd544a7c3d3860d) Fix comment for upload ### 📊 Changes **2 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/controllers/MiscController.js` (+3 -2) 📝 `server/controllers/PodcastController.js` (+3 -2) </details> ### 📄 Description Fixes https://github.com/advplyr/audiobookshelf/issues/3353, or at least the cause of two crashes I was able to identify in that issue. I am not sure if there are other places where a similar problem occurs. This PR uses the `libraryFolders` table to ensure the folder exists. This was just my attempt at a quick fix, so no worries if there's a better/easier way to resolve the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:40 +02:00
adam closed this issue 2026-04-25 00:17:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?