starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #461] [MERGED] Convert timeListened to float #3354

New Issue
Closed
opened 2026-04-25 00:15:20 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:20 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/461
Author: @rasmuslos
Created: 4/15/2022
Status: ✅ Merged
Merged: 4/15/2022
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (4)

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 server/managers/PlaybackSessionManager.js (+1 -1)
📝 server/objects/PlaybackSession.js (+1 -1)

📄 Description

When timeListened was a string ("33") not a number (33) this.timeListening = 4 would get updated to 433 not 37

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/461 **Author:** [@rasmuslos](https://github.com/rasmuslos) **Created:** 4/15/2022 **Status:** ✅ Merged **Merged:** 4/15/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`09dd90e`](https://github.com/advplyr/audiobookshelf/commit/09dd90e3fc7f3663c79f9db9b3d315eb847c1d13) Convert timeListened to int - [`cd5e509`](https://github.com/advplyr/audiobookshelf/commit/cd5e5099f26c15fbd0e0c7e91ba6c58d30559d3d) Merge branch 'advplyr:master' into master - [`e924943`](https://github.com/advplyr/audiobookshelf/commit/e9249430c37866341bab2056d7d0b98988371f35) Parse current time as float - [`cd274e0`](https://github.com/advplyr/audiobookshelf/commit/cd274e084410911ab56fadaf0ee0b699a64b26e4) Merge branch 'master' of https://github.com/rasmuslos/audiobookshelf ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/PlaybackSessionManager.js` (+1 -1) 📝 `server/objects/PlaybackSession.js` (+1 -1) </details> ### 📄 Description When `timeListened` was a string (`"33"`) not a number (`33`) `this.timeListening = 4` would get updated to `433` not `37` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:20 +02:00
adam closed this issue 2026-04-25 00:15:20 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?