starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #3294] [MERGED] Refactor menu keyoboard navigation into mixin #3923

New Issue
Closed
opened 2026-04-25 00:17:35 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:35 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/3294
Author: @mikiher
Created: 8/17/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @advplyr

Base: master ← Head: menu-keyboard-navigation-refactor

📝 Commits (1)

  • f1ddbea Refactor menu keyoboard navigation into mixin

📊 Changes

5 files changed (+110 additions, -107 deletions)

View changed files

📝 client/components/modals/EditSeriesInputInnerModal.vue (+7 -2)
📝 client/components/ui/InputDropdown.vue (+8 -2)
📝 client/components/ui/MultiSelect.vue (+6 -51)
📝 client/components/ui/MultiSelectQueryInput.vue (+6 -52)
➕ client/mixins/menuKeyboardNavigation.js (+83 -0)

📄 Description

This fixes #3286 while refactoring the menu keyboard navigation functions into a mixin for reusability.

Aside from the refactoring, there are a couple of functional changes:

  • Added menu navigation to InputDropdown.vue (which implements the feature request above)
  • In the Add Series dialog, when the series name is accepted, the focus automatically moves to the Sequence input. This was done in order to streamline keyboard editing
  • In MultiSelect.vue and MultSelectQueryInput.vue, I removed the bluring in insertNewItem(). This was also to streamline keyboard editing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/3294 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 8/17/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `menu-keyboard-navigation-refactor` --- ### 📝 Commits (1) - [`f1ddbea`](https://github.com/advplyr/audiobookshelf/commit/f1ddbeadaf53a489cc30fc50c5c148a42d473aaf) Refactor menu keyoboard navigation into mixin ### 📊 Changes **5 files changed** (+110 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `client/components/modals/EditSeriesInputInnerModal.vue` (+7 -2) 📝 `client/components/ui/InputDropdown.vue` (+8 -2) 📝 `client/components/ui/MultiSelect.vue` (+6 -51) 📝 `client/components/ui/MultiSelectQueryInput.vue` (+6 -52) ➕ `client/mixins/menuKeyboardNavigation.js` (+83 -0) </details> ### 📄 Description This fixes #3286 while refactoring the menu keyboard navigation functions into a mixin for reusability. Aside from the refactoring, there are a couple of functional changes: - Added menu navigation to `InputDropdown.vue` (which implements the feature request above) - In the Add Series dialog, when the series name is accepted, the focus automatically moves to the Sequence input. This was done in order to streamline keyboard editing - In `MultiSelect.vue` and `MultSelectQueryInput.vue`, I removed the bluring in `insertNewItem()`. This was also to streamline keyboard editing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:35 +02:00
adam closed this issue 2026-04-25 00:17:35 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3923
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?