starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #2784] [MERGED] Fix custom metadata provider crash #3803

New Issue
Closed
opened 2026-04-25 00:17:08 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:17:08 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/2784
Author: @rasmuslos
Created: 3/23/2024
Status: ✅ Merged
Merged: 3/23/2024
Merged by: @advplyr

Base: master ← Head: patch-1

📝 Commits (1)

  • 9615337 Fix custom metadata provider crash

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/finders/BookFinder.js (+1 -1)

📄 Description

The method search(title, author, isbn, providerSlug, mediaType) (CustomProviderAdapter#17) expects five arguments but only receives four. This causes a crash because no custom metadata provider book (passed as forth argument, not fifth) does exist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/2784 **Author:** [@rasmuslos](https://github.com/rasmuslos) **Created:** 3/23/2024 **Status:** ✅ Merged **Merged:** 3/23/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`9615337`](https://github.com/advplyr/audiobookshelf/commit/961533765f8006492c3c1ee8c877ab29c255e32c) Fix custom metadata provider crash ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/finders/BookFinder.js` (+1 -1) </details> ### 📄 Description The method `search(title, author, isbn, providerSlug, mediaType)` (`CustomProviderAdapter#17`) expects five arguments but only receives four. This causes a crash because no custom metadata provider `book` (passed as forth argument, not fifth) does exist --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:17:08 +02:00
adam closed this issue 2026-04-25 00:17:08 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?