starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1838] [MERGED] Updates to Email settings/manager to include test email #3627

New Issue
Closed
opened 2026-04-25 00:16:24 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:24 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1838
Author: @daVinci2793
Created: 6/12/2023
Status: ✅ Merged
Merged: 6/13/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • d54edb9 Updates to Email settings/manager to include test email
  • d748d43 Fallback to using from address if test address is not set, add reset button when form has changes

📊 Changes

15 files changed (+29 additions, -2 deletions)

View changed files

📝 client/pages/config/email.vue (+12 -1)
📝 client/strings/de.json (+1 -0)
📝 client/strings/en-us.json (+1 -0)
📝 client/strings/es.json (+1 -0)
📝 client/strings/fr.json (+1 -0)
📝 client/strings/gu.json (+1 -0)
📝 client/strings/hi.json (+1 -0)
📝 client/strings/hr.json (+1 -0)
📝 client/strings/it.json (+1 -0)
📝 client/strings/nl.json (+1 -0)
📝 client/strings/pl.json (+1 -0)
📝 client/strings/ru.json (+1 -0)
📝 client/strings/zh-cn.json (+1 -0)
📝 server/managers/EmailManager.js (+2 -1)
📝 server/objects/settings/EmailSettings.js (+3 -0)

📄 Description

Made minor updates to Email manager and settings to include a "Test Address."

Justification: Some smtp relays and/or APIs do not inherently support receiving emails. Ideally, the Email Test button would include a customizable recipient. Allowing users to arbitrarily input an email address to send the test email to instead of assuming the "From Address" is capable of receiving emails.

Here are the changes made to the client:
image

Additionally, I added a simple fixed string Subject to the Ebook Email transporter. There was something jarring about seeing (NO SUBJECT) and that might get filtered out.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1838 **Author:** [@daVinci2793](https://github.com/daVinci2793) **Created:** 6/12/2023 **Status:** ✅ Merged **Merged:** 6/13/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`d54edb9`](https://github.com/advplyr/audiobookshelf/commit/d54edb93d6a6261c252ab696842ff2433a47a079) Updates to Email settings/manager to include test email - [`d748d43`](https://github.com/advplyr/audiobookshelf/commit/d748d43efcec8ad65d85be01be05187a943b857a) Fallback to using from address if test address is not set, add reset button when form has changes ### 📊 Changes **15 files changed** (+29 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/config/email.vue` (+12 -1) 📝 `client/strings/de.json` (+1 -0) 📝 `client/strings/en-us.json` (+1 -0) 📝 `client/strings/es.json` (+1 -0) 📝 `client/strings/fr.json` (+1 -0) 📝 `client/strings/gu.json` (+1 -0) 📝 `client/strings/hi.json` (+1 -0) 📝 `client/strings/hr.json` (+1 -0) 📝 `client/strings/it.json` (+1 -0) 📝 `client/strings/nl.json` (+1 -0) 📝 `client/strings/pl.json` (+1 -0) 📝 `client/strings/ru.json` (+1 -0) 📝 `client/strings/zh-cn.json` (+1 -0) 📝 `server/managers/EmailManager.js` (+2 -1) 📝 `server/objects/settings/EmailSettings.js` (+3 -0) </details> ### 📄 Description Made minor updates to Email manager and settings to include a "Test Address." Justification: Some smtp relays and/or APIs do not inherently support receiving emails. Ideally, the Email Test button would include a customizable recipient. Allowing users to arbitrarily input an email address to send the test email to instead of assuming the "From Address" is capable of receiving emails. Here are the changes made to the client: ![image](https://github.com/advplyr/audiobookshelf/assets/49510984/0a36e28d-6ad1-47a3-b548-e575af5fbd76) Additionally, I added a simple fixed string Subject to the Ebook Email transporter. There was something jarring about seeing (NO SUBJECT) and that might get filtered out. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:24 +02:00
adam closed this issue 2026-04-25 00:16:25 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?