starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1420] [MERGED] Fix HTTP links not working in podcast show notes. #3538

New Issue
Closed
opened 2026-04-25 00:16:03 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:16:03 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1420
Author: @Bostrolicious
Created: 1/21/2023
Status: ✅ Merged
Merged: 1/22/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • 9e095a4 Fix HTTP links not working in podcast show notes.
  • 89d497a Fix mailto links not working in podcast show notes.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/utils/htmlSanitizer.js (+1 -1)

📄 Description

Fixes #1418. HTTP links in show notes didn't work because sanitize in server/utils/htmlSanitizer.js removes them, as only https was set in allowedSchemes. This commit adds http.

htmlSanitizer/sanitize is only used for podcast and episode descriptions (in server/utils/podcastUtils.js and server/providers/iTunes.js) , so I don't think there's any reason to disallow HTTP.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1420 **Author:** [@Bostrolicious](https://github.com/Bostrolicious) **Created:** 1/21/2023 **Status:** ✅ Merged **Merged:** 1/22/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`9e095a4`](https://github.com/advplyr/audiobookshelf/commit/9e095a4bc11d176f97e1c71661360234ce4ef89a) Fix HTTP links not working in podcast show notes. - [`89d497a`](https://github.com/advplyr/audiobookshelf/commit/89d497a3059d457680ce8b711b67e475cfca3375) Fix mailto links not working in podcast show notes. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/htmlSanitizer.js` (+1 -1) </details> ### 📄 Description Fixes #1418. HTTP links in show notes didn't work because `sanitize` in `server/utils/htmlSanitizer.js` removes them, as only `https` was set in `allowedSchemes`. This commit adds `http`. `htmlSanitizer/sanitize` is only used for podcast and episode descriptions (in `server/utils/podcastUtils.js` and `server/providers/iTunes.js`) , so I don't think there's any reason to disallow HTTP. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:16:03 +02:00
adam closed this issue 2026-04-25 00:16:03 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?