starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #1110] [MERGED] Added tone json file support #3447

New Issue
Closed
opened 2026-04-25 00:15:41 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:41 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/1110
Author: @keaganhilliard
Created: 11/3/2022
Status: ✅ Merged
Merged: 11/5/2022
Merged by: @advplyr

Base: master ← Head: tone-json

📝 Commits (5)

  • c1938f7 Added json file support
  • d57effe Fixed a couple of issues, should be working well now
  • 586c8a5 Removed a noisy log and limit chapter embedding to items with only 1 audiofile
  • 3824154 Forgot to update the merge
  • 1118b8b Metadata embed and m4b merge fixes and cleanup

📊 Changes

5 files changed (+98 additions, -36 deletions)

View changed files

📝 client/pages/audiobook/_id/manage.vue (+4 -0)
📝 server/controllers/LibraryItemController.js (+2 -1)
📝 server/managers/AbMergeManager.js (+13 -16)
📝 server/managers/AudioMetadataManager.js (+15 -19)
📝 server/utils/toneHelpers.js (+64 -0)

📄 Description

This is an academic PR, I haven't been able to test it, but the logic checks out in my head haha.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/1110 **Author:** [@keaganhilliard](https://github.com/keaganhilliard) **Created:** 11/3/2022 **Status:** ✅ Merged **Merged:** 11/5/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `tone-json` --- ### 📝 Commits (5) - [`c1938f7`](https://github.com/advplyr/audiobookshelf/commit/c1938f78c24feff8d81cf7bb4b7c17a714d8ad79) Added json file support - [`d57effe`](https://github.com/advplyr/audiobookshelf/commit/d57effe97cb6dbee7ad7a28a4688bc85aa4e5554) Fixed a couple of issues, should be working well now - [`586c8a5`](https://github.com/advplyr/audiobookshelf/commit/586c8a550a9b53487aabd13fa47d44626cf1da09) Removed a noisy log and limit chapter embedding to items with only 1 audiofile - [`3824154`](https://github.com/advplyr/audiobookshelf/commit/3824154c15fa6f86d121ef8db5da77c2c3154079) Forgot to update the merge - [`1118b8b`](https://github.com/advplyr/audiobookshelf/commit/1118b8b78200704d2c16c5c36f7fccc70e5d0f4f) Metadata embed and m4b merge fixes and cleanup ### 📊 Changes **5 files changed** (+98 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `client/pages/audiobook/_id/manage.vue` (+4 -0) 📝 `server/controllers/LibraryItemController.js` (+2 -1) 📝 `server/managers/AbMergeManager.js` (+13 -16) 📝 `server/managers/AudioMetadataManager.js` (+15 -19) 📝 `server/utils/toneHelpers.js` (+64 -0) </details> ### 📄 Description This is an academic PR, I haven't been able to test it, but the logic checks out in my head haha. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:41 +02:00
adam closed this issue 2026-04-25 00:15:41 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?