starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #682] [MERGED] Support embedding cover art metadata in the embed metadata tool #3395

New Issue
Closed
opened 2026-04-25 00:15:29 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:29 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/682
Author: @jmt-gh
Created: 6/5/2022
Status: ✅ Merged
Merged: 6/5/2022
Merged by: @advplyr

Base: master ← Head: update_cover_on_merge

📝 Commits (3)

  • d6c02eb Support embedding cover art metadata
  • 9b6fa8f Merge branch 'advplyr:master' into update_cover_on_merge
  • 8809c7b Handle null and delete cover cases

📊 Changes

1 file changed (+32 additions, -2 deletions)

View changed files

📝 server/managers/AudioMetadataManager.js (+32 -2)

📄 Description

Added support for chapter metadata in #678, but completely missed that coverart wasn't getting embedded in the embed metadata tool. This commit adds that in.

I tested this by putting an m4b in my library, scraping a new cover, embedding the metadata through the embed tool, and then opening in VLC to validate the new cover is there

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/682 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 6/5/2022 **Status:** ✅ Merged **Merged:** 6/5/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `update_cover_on_merge` --- ### 📝 Commits (3) - [`d6c02eb`](https://github.com/advplyr/audiobookshelf/commit/d6c02ebb2c527871ff7e22efb2fcac29ddd6b0f9) Support embedding cover art metadata - [`9b6fa8f`](https://github.com/advplyr/audiobookshelf/commit/9b6fa8fe8c2303b4020a899691d493c0f04c4292) Merge branch 'advplyr:master' into update_cover_on_merge - [`8809c7b`](https://github.com/advplyr/audiobookshelf/commit/8809c7b900b87655adaea5d1d457da2a1fb4f6bf) Handle null and delete cover cases ### 📊 Changes **1 file changed** (+32 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/AudioMetadataManager.js` (+32 -2) </details> ### 📄 Description Added support for chapter metadata in #678, but completely missed that coverart wasn't getting embedded in the embed metadata tool. This commit adds that in. I tested this by putting an m4b in my library, scraping a new cover, embedding the metadata through the embed tool, and then opening in VLC to validate the new cover is there --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:29 +02:00
adam closed this issue 2026-04-25 00:15:29 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3395
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?