starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #678] [MERGED] Support embedding updated chapter metadata (issue #676) #3389

New Issue
Closed
opened 2026-04-25 00:15:28 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:15:28 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/678
Author: @jmt-gh
Created: 6/4/2022
Status: ✅ Merged
Merged: 6/4/2022
Merged by: @advplyr

Base: master ← Head: issue_676_chapter_metadata

📝 Commits (1)

  • ab0094a Support embedding updated chapter metadata (676)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 server/managers/AudioMetadataManager.js (+2 -2)

📄 Description

This commit resolves issue #676 . The embed metadata tool was missing the flag that tells ffmpeg to not only update the "top" metadata, but also the chapter metadata.

I tested this manually by adding a file to my library and testing before and after this change, and validating the change through ffprobe.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/678 **Author:** [@jmt-gh](https://github.com/jmt-gh) **Created:** 6/4/2022 **Status:** ✅ Merged **Merged:** 6/4/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `issue_676_chapter_metadata` --- ### 📝 Commits (1) - [`ab0094a`](https://github.com/advplyr/audiobookshelf/commit/ab0094a53ba676289dfcc3f9eaaef64f390902f9) Support embedding updated chapter metadata (676) ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/managers/AudioMetadataManager.js` (+2 -2) </details> ### 📄 Description This commit resolves issue #676 . The embed metadata tool was missing the flag that tells ffmpeg to not only update the "top" metadata, but also the chapter metadata. I tested this manually by adding a file to my library and testing before and after this change, and validating the change through ffprobe. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:15:28 +02:00
adam closed this issue 2026-04-25 00:15:28 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#3389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?