mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Embed Metadata Not Working At All Anymore #2032
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2032
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @EnduringGuerila on GitHub (Jun 5, 2024).
What happened?
I was editing the Halo collection of m4b files while on abs v2.9.x, I ran into file permissions issues on a few of them not writing and forgot I had made hardlinks and another program had locked the files. In initial attempt to fix the issue, I updated ABS do 2.10.1 and now I can't embed metadata in any files!
The initial permissions issue just didn't change the existing tags.
Now, all existing tags get wiped and no new tags get written
Reading the logs, it says it was successful after taking way longer than it used to
the example below, Epitaph was one of the files that had properly embeded metadata before the update. upon rerunning the embed process, no metadata tags exist now.
What did you expect to happen?
Metadata getting written to m4b
Steps to reproduce the issue
Audiobookshelf version
2.10.1
How are you running audiobookshelf?
Debian/PPA
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
No response
@nichwall commented on GitHub (Jun 5, 2024):
Related to https://github.com/advplyr/audiobookshelf/issues/1085
https://github.com/advplyr/audiobookshelf/issues/2557
Most likely
https://github.com/advplyr/audiobookshelf/issues/3029
There has not been any changes to how files are combined or metadata is embedded, so it is probably an issue with the m4b since you said it worked for that book before.
There was an issue with ffmpeg not being included correctly on 2.10.0 with the PPA install method, but that was fixed in 2.10.1
Does embedding work with 2.9.0?
@advplyr commented on GitHub (Jun 5, 2024):
This should be the same as #3029, specific to the Debian package but I'm not sure why you wouldn't be seeing the error log.
Can you check the log for something similar to:
@EnduringGuerila commented on GitHub (Jun 6, 2024):
The only 'error' listed is a Thumbs.db file I deleted after restarting explorer.exe on my desktop. There are no other errors I can find. Do you want me to upload the full log?
@EnduringGuerila commented on GitHub (Jun 6, 2024):
here is Epitaph.m4b after attempting to embed new tags:
and here is another file before attempting to embed updated tags:
so again, it's not just failing to do anything, it's wiping what's there.
and Epitaph was a file that abs had successfully embeded on 2.9.x and I only reran it on 2.10.1 as a test.
@EnduringGuerila commented on GitHub (Jun 6, 2024):
log
@EnduringGuerila commented on GitHub (Jun 8, 2024):
So, I downgraded back to 2.9.0 and it didn't start working again.
Here is the update log of the other packages that updated at the same time that I originally updated to 2.10.1:
@advplyr commented on GitHub (Jun 13, 2024):
I'm not sure what to do here. Is the embed still not working for you?
@EnduringGuerila commented on GitHub (Jun 28, 2024):
sorry, not getting notifications for some reason.
no, the embed is still not working
@EnduringGuerila commented on GitHub (Jul 19, 2024):
I just upgraded to 2.11.0 and tried a single quick embed, and it worked. I'll do more testing but the issue might be resolved.
@EnduringGuerila commented on GitHub (Jul 19, 2024):
After further testing, I selected about 30 books in ABS and clicked "quick embed metadata" in the top right menu, and this did not work.
It attempted to process each of the books,
the library kept rescanning as it processed and said it was finding new books,
I checked the files and I know for sure many of them did not update. I don't know what the old tags were on some of them so a few MIGHT have updated but it SEEMS like none of them updated.
when going to the "Audiobook File Management Tools" section, it shows "Embed Finished!" on the files that I confirmed did not actually embed.
When opening the Edit menu, going to Tools tab and clicking 'Quick Embed' on a single book, embedding seems to work just fine.
@EnduringGuerila commented on GitHub (Jul 19, 2024):
I just did 8 books by quickly going into Edit/Tools and Quick Embed for each one separately, and only first 4 succeeded. I wonder if doing books too soon after another is causing issues. I redid quick embed in the last 4 that didn't embed and they embedded just fine. I also just watched the folder more closely on another monitor while embedding, and it seems like the files are being copied, tags applied to the new file and then the old file is replaced by the new one. The Creation Date is still showing the old date but I don't think that means much in my experience transferring files via SFTP in the past.
I do have ABS running in an LXC container on Proxmox with only 2 cpu cores and 2gb of ram. ABS is on an NVMe SSD but the files are on a 10gbe network share. I haven't had any other read/write issues on the network share, no matter how quickly I change/read/write files so I don't think that's an issue...
@nichwall commented on GitHub (Jul 19, 2024):
Are all of the books a single m4b file? Do you have any logs for the ones that worked/failed?
@EnduringGuerila commented on GitHub (Jul 19, 2024):
Each book is its own, single m4b file.
When going through each one individually, Halo book 17, Saint's Testimony kept 'finishing' instantly but wasn't updating. This wasn't the norm, usually it takes like 3 seconds to process whether it updates or not. THAT log says:
I'll try to find another one that fails from me going too fast and see what the log says
@nichwall commented on GitHub (Jul 19, 2024):
Are the ones that fail the only ones with an apostrophe (or another special character) in the filename?
@EnduringGuerila commented on GitHub (Jul 19, 2024):
That's the only book with an apostrophe in the title, the rest might have one in the description though.
I just selected books 27-34, clicked the button to mass "quick embed metadata" and at least book 27-33 did NOT update. I don't know if I previously updated 34 and it also failed or if it successfully updated this time.
Here is the error for book 27:
Here is the log from book 34:
@EnduringGuerila commented on GitHub (Jul 19, 2024):
I just ran book 27 individually and it succeeded but showed an error anyway:
Book 27 run individually
@EnduringGuerila commented on GitHub (Jul 19, 2024):
I finished embedding the updated metadata in all of the files individually and I did not get another failure for going to quickly. I can do further testing but I wanted to finally have good, updated versions of these 35 books...
@user2223 commented on GitHub (Jul 22, 2024):
Chiming in, I have noticed that metadata doesn't seem to be written while creating an M4B file since the 2.11 update.
I just converted a few hundred audiobooks to M4B after the M4B creation got fixed, and now all new books are missing embedded metadata. It seems to work fine using Quick Embed afterwards.
One thing that I noticed is that the ASIN is not saved in the metadata anymore. Subtitle and title get merged, language and publisher are missing, and tags are still not embedded.
It would be really nice to have the option to embed all metadata that is available in ABS, especially ASIN, series, and title + subtitle, which are quite important to me.
Here are Screenshots, the file with the tags was created using an older version of abs, the one without tags is the state after creating the m4b file. The metadata in abs is filled for both audiobooks.
Here is a file that hat the metadata set as expected (this is the result when using an abs version older than 2.10):
This is what the tags look like right after creating the m4b:
This Screenshot shows the metadata of the second audiobook after a quick embed. There are Tags missing compared to the first picture.
My current workaround is:
This results in files with the correct metadata (some covers are off due to multiple image files in the folder but that is not a big issue.
@katertier commented on GitHub (Aug 4, 2024):
Can confirm:
2.11.0, Docker 4.33.0 on Mac OS X:
These are shown when I used Extended Tags dialogue in MP3Tag, file is an m4v (iso2mp41M4A)
Before (set with MP3Tag):
ALBUM Sakura
ALBUMARTIST Zachary Hill, Patrick M. Tracy, Paul Genesse, Larry Correia - foreword
ALBUMSORT Sakura - Intellectual Property
ASIN 1400193001
COMMENT Sakura is the most famous android rock star of all time. When a secret cabal hacks her system, she's transformed into a deadly assassin, forced to kill at their biddi...
COMPOSER Emily Woo Zeller
GENRE Science Fiction & Fantasy / Fantasy / Superhero
GENRE Science Fiction & Fantasy / Science Fiction / Cyberpunk
GENRE Science Fiction & Fantasy / Science Fiction / Dystopian
ITUNESGAPLESS 1
ITUNESMEDIATYPE Audiobook
PUBLISHER Tantor Audio
RATING 4.5
RELEASETIME 2019-11-26
SUBTITLE Intellectual Property
YEAR 2019
After (set with Audiobookshelf)
ALBUM Sakura: Intellectual Property
ALBUMARTIST Zachary Hill, Patrick M. Tracy, Paul Genesse, Larry Correia - foreword
ARTIST Zachary Hill, Patrick M. Tracy, Paul Genesse, Larry Correia - foreword
COMMENT Sakura is the most famous android rock star of all time. When a secret cabal hacks her system, she's transformed into a deadly assassin, forced to...
COMMENT Sakura is the most famous android rock star of all time. When a secret cabal hacks her system, she's transformed into a deadly assassin, forced to...
COMPOSER Emily Woo Zeller
COPYRIGHT Tantor Audio
GENRE Science Fiction & Fantasy; Fantasy
ITUNESGAPLESS 1
ITUNESMEDIATYPE Audiobook
TITLE Sakura
TRACK 1
YEAR 2019
@advplyr commented on GitHub (Sep 11, 2024):
Still not sure what to do here but some updates were made to m4b embed since this issue was opened.
Is this still a problem on v2.13.4?
@EnduringGuerila commented on GitHub (Sep 17, 2024):
It was at least partially fixed back on July 18th and I haven't tested much since then as it was mostly working. I might find some time to do more testing just to see if I can recreate any issues.
@user2223 commented on GitHub (Sep 17, 2024):
The conversion works and does not clear the metadata anymore, the resulting metadata is still missing the ASIN for example.
This is the metadata using the latest version of ABS:
Here is the Metadata with 2.8.1:
The Metadata in ABS is the same for both.
