starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-26 14:38:39 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1094] [MERGED] Disable ios/android scrubbing in MPRemoteCommandCenter/MediaBrowserServiceCompat #1497

New Issue
Closed
opened 2026-04-24 23:58:52 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:52 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1094
Author: @fidoriel
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/25/2024
Merged by: @advplyr

Base: master ← Head: disable-widget-ios-scrubing

📝 Commits (9)

  • 41a65c0 add setting for widget scrubbing
  • d2d3bbe fix default false
  • b6fea85 fix compile android
  • 8235d1f reorder setting and add info label
  • 7be82d0 Merge branch 'master' into disable-widget-ios-scrubing
  • 430d200 Update android disable media control seek setting to update in realtime
  • f4f7252 Update wording for enable seeking on media controls settings, remove restart required help text, map translations
  • 9706c66 iOS Update Realm schema version for new setting, update remote transport controls on device settings updated
  • 8c23c1e german translation for LabelAllowSeekingOnMediaControls

📊 Changes

28 files changed (+77 additions, -17 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/MainActivity.kt (+3 -0)
📝 android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt (+2 -0)
📝 android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationService.kt (+15 -9)
📝 android/app/src/main/java/com/audiobookshelf/app/plugins/AbsDatabase.kt (+10 -1)
📝 ios/App/App/AppDelegate.swift (+1 -1)
📝 ios/App/App/plugins/AbsDatabase.swift (+5 -1)
📝 ios/App/Shared/models/DeviceSettings.swift (+2 -0)
📝 ios/App/Shared/player/AudioPlayer.swift (+2 -2)
📝 ios/App/Shared/player/PlayerHandler.swift (+4 -0)
📝 pages/settings.vue (+12 -0)
📝 strings/cs.json (+2 -1)
📝 strings/da.json (+1 -0)
📝 strings/de.json (+1 -0)
📝 strings/en-us.json (+1 -0)
📝 strings/es.json (+1 -0)
📝 strings/fr.json (+1 -0)
📝 strings/gu.json (+1 -0)
📝 strings/hi.json (+1 -0)
📝 strings/hr.json (+1 -0)
📝 strings/it.json (+2 -1)

...and 8 more files

📄 Description

This could close #526 #1093 #691
Similar to #683. I do not know why #683 this was closed in the first place by the author.

Scrubbing through some kind of audio with a length > 30 minutes is objectively not possible in an accurate way.
Disabling has the benefit that the audiobook position can not be changed by accident.

Tested and Working on iPhone 13 mini, iOS 17.2.1

This is mainly a discussion about usability and philosophy of use, if this is the correct approach without a setting.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1094 **Author:** [@fidoriel](https://github.com/fidoriel) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/25/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `disable-widget-ios-scrubing` --- ### 📝 Commits (9) - [`41a65c0`](https://github.com/advplyr/audiobookshelf-app/commit/41a65c0f9dff6f866c3fbebf3ce79b2234dc6741) add setting for widget scrubbing - [`d2d3bbe`](https://github.com/advplyr/audiobookshelf-app/commit/d2d3bbe8a15b268c29dcacf2342f74747fec298f) fix default false - [`b6fea85`](https://github.com/advplyr/audiobookshelf-app/commit/b6fea85ef40d737d701c430848a09cafd35f8f60) fix compile android - [`8235d1f`](https://github.com/advplyr/audiobookshelf-app/commit/8235d1f1f771c6b07990c61549dff4216809a4dc) reorder setting and add info label - [`7be82d0`](https://github.com/advplyr/audiobookshelf-app/commit/7be82d03f3bfb082610f54b003ef050ee34e8d66) Merge branch 'master' into disable-widget-ios-scrubing - [`430d200`](https://github.com/advplyr/audiobookshelf-app/commit/430d20015102c555a676573f1f9abda2dd39e032) Update android disable media control seek setting to update in realtime - [`f4f7252`](https://github.com/advplyr/audiobookshelf-app/commit/f4f725253791d868e74287d6fb28555634b38db1) Update wording for enable seeking on media controls settings, remove restart required help text, map translations - [`9706c66`](https://github.com/advplyr/audiobookshelf-app/commit/9706c66a27e08b6fcb551218ba08d2b54bc4ab52) iOS Update Realm schema version for new setting, update remote transport controls on device settings updated - [`8c23c1e`](https://github.com/advplyr/audiobookshelf-app/commit/8c23c1e795f9d7ebb4a9030d8e8bcdd973c470a5) german translation for LabelAllowSeekingOnMediaControls ### 📊 Changes **28 files changed** (+77 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/MainActivity.kt` (+3 -0) 📝 `android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt` (+2 -0) 📝 `android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationService.kt` (+15 -9) 📝 `android/app/src/main/java/com/audiobookshelf/app/plugins/AbsDatabase.kt` (+10 -1) 📝 `ios/App/App/AppDelegate.swift` (+1 -1) 📝 `ios/App/App/plugins/AbsDatabase.swift` (+5 -1) 📝 `ios/App/Shared/models/DeviceSettings.swift` (+2 -0) 📝 `ios/App/Shared/player/AudioPlayer.swift` (+2 -2) 📝 `ios/App/Shared/player/PlayerHandler.swift` (+4 -0) 📝 `pages/settings.vue` (+12 -0) 📝 `strings/cs.json` (+2 -1) 📝 `strings/da.json` (+1 -0) 📝 `strings/de.json` (+1 -0) 📝 `strings/en-us.json` (+1 -0) 📝 `strings/es.json` (+1 -0) 📝 `strings/fr.json` (+1 -0) 📝 `strings/gu.json` (+1 -0) 📝 `strings/hi.json` (+1 -0) 📝 `strings/hr.json` (+1 -0) 📝 `strings/it.json` (+2 -1) _...and 8 more files_ </details> ### 📄 Description This could close #526 #1093 #691 Similar to #683. I do not know why #683 this was closed in the first place by the author. Scrubbing through some kind of audio with a length > 30 minutes is objectively not possible in an accurate way. Disabling has the benefit that the audiobook position can not be changed by accident. Tested and Working on iPhone 13 mini, iOS 17.2.1 This is mainly a discussion about usability and philosophy of use, if this is the correct approach without a setting. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:52 +02:00
adam closed this issue 2026-04-24 23:58:52 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1497