mirror of
https://github.com/advplyr/audiobookshelf-app.git
synced 2026-07-25 22:18:38 +02:00
[Bug]: No socket connection, inaccurate connection status indication #1199
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf-app#1199
Reference in New Issue
Block a user
Originally created by @noticons on GitHub (Apr 28, 2025).
I have verified that the bug is not already awaiting release
Yes
What was the Problem?
In the spirit of adding an issue that occurs without a socket connection, I get a wrong connection status indication. I still have connection and can do anything that I could normally do, however (including switch between books and podcasts now, thank you). Here's what I mean:
It says there is no connection, but is wrong:
Steps to Reproduce the Issue
Use a AOSP version of Android, like CalyxOS, and the audiobookshelf app.
What was Expected?
For regular connectivity to work. I am using the very latest version of Audiobookshelf (9.81)
Phone Model
Pixel 8
Phone OS
Android15
Audiobookshelf App Version
Android App - 0.9.79
Installation Source
Other (List in "Additional Notes")
Additional Notes
fdroid repo, izzy. The latest version of the app, not 9.79--I'm using 9.81
@Vito0912 commented on GitHub (Apr 28, 2025):
If you are using a reverse proxy, you need to enable websocket support.
@noticons commented on GitHub (Apr 28, 2025):
Thanks! I'm sure that'll be very helpful for someone to hear. I have a straight, local connection on the same network.
I should have been more clear. This is in relation to a bug related to using AOSP platforms that hinder any websocket connections in webview--or something. So this is more in response to the request made originally by @advplyr in #1494
@Vito0912 commented on GitHub (Apr 28, 2025):
Ah, okay. That makes sense.
What I do not understand now is what you mean by "wrong status indication."
Your screenshots show the correct messages for a connection that does not allow WebSockets.
As long as no feature does not work, this is expected to be shown in your situation.
While WebSockets are not required to use the app, it is highly recommended to have them enabled (even though that seems complicated in your case). Therefore, a connection without a socket is not a full connection and should show a warning to the users that features are not working as intended.
Sorry if I am completely misunderstanding your issue right now.
@advplyr commented on GitHub (Apr 28, 2025):
Yeah I basically said the same thing before seeing this new issue opened: https://github.com/advplyr/audiobookshelf-app/issues/1559#issuecomment-2835253683
@noticons commented on GitHub (Apr 28, 2025):
Yes, the github bot closed that issue because I didn't use a template, so I opened an issue using the template. Sorry for the confusion.
I don't deny that CalyxOS has a websocket problem in their webview implementation (When I used GrapheneOS, everything worked fine). It is frustrating for this one app. I do, however, have no problem with any of the features of the app, especailly now that you enabled the dropdown menu for Audiobooks and Podcasts.
My only point here is just the indication that there is no server connection by the cloud with the cross through it,
This same icon (decolorized) is used in the menu to disconnect, which makes one think there is no connection. I don't mind the erroneous indication that my app is disconnected from the server. It is easily ignored. And I understand that there is a websocket issue in CalyxOS. I only brought it up because it is literally the only other issue I have without a websocket connection. Thanks! I really do enjoy audiobookshelf as a server and the app!
@advplyr commented on GitHub (Apr 28, 2025):
I see, we could choose a different icon if there is a better one but we want to show that there is no socket connection. Do you have a different icon you can suggest?
@noticons commented on GitHub (Apr 28, 2025):
I know this is largely a subjective answer, but perhaps an icon like this:
which, in my linux installation is found here:
/usr/share/icons/breeze-dark/actions/22/network-disconnect.svg
I'm not tied to it. I'm sure someone else has a more excellent suggestion.
@nichwall commented on GitHub (Apr 28, 2025):
What about
link-off?https://fonts.google.com/icons?selected=Material+Symbols+Outlined:link_off:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=link&icon.size=24&icon.color=%23e3e3e3
@noticons commented on GitHub (May 21, 2025):
@nichwall I tried your link but couldn't see it. I'm sure it's my problem, but could you please take a screenshot of the icon?
Also, I'm not sure what the regs are for fonts other than general copyright. I'm guessing that google's font set for "Material Symbols" is legally available to use?
@nichwall commented on GitHub (May 21, 2025):
Yes, we use Material Symbols (previously Material Icons) because it is a stand icon set that is used by many projects and the intent behind why Google maintains the icon set (standardization).
Edit to add link to their FAQ https://developers.google.com/fonts/faq
@noticons commented on GitHub (May 21, 2025):
I'm perfectly fine with either icon. But seeing that you are already using that icon set, I suppose it is much easier to stay within that font. I'm for that (@nichwall material symbol
link-off)My primary concern is a normie using the app and seeing that the cloud with the cross through it would mean no connection whatsoever, as it is also used in the “hamburger” menu to indicate disconnecting from the server. Therefore, having another icon of a different type would indicate different statuses.
Thank you so much.