starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-08-06 20:08:48 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

Merge pull request #1523 from complacentsee/ios_seekbacktrackbugfix

Browse Source 
iOS: Bugfix: resolve race condition when rebuilding queue for seeking back
This commit is contained in:
advplyr
2025-03-22 17:56:07 -05:00
committed by GitHub
parent a6d49fc926 647bd8193b
commit 8b370da5b7
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ios/App/Shared/player/AudioPlayer.swift
+14
View File
@@ -45,6 +45,8 @@ class AudioPlayer: NSObject {
private var queueObserver:NSKeyValueObservation?
private var queueItemStatusObserver:NSKeyValueObservation?
private var isRebuildingQueue = false
// Sleep timer values
internal var sleepTimeChapterStopAt: Double?
internal var sleepTimeChapterToken: Any?
@@ -434,10 +436,14 @@ class AudioPlayer: NSObject {
let playerItems = self.allPlayerItems[indexOfSeek..<self.allPlayerItems.count]
DispatchQueue.runOnMainQueue {
// Let observers know we're rebuilding the queue
// prevents race conditions on stopping sessions if queue is empty.
self.isRebuildingQueue = true
self.audioPlayer.removeAllItems()
for item in Array(playerItems) {
self.audioPlayer.insert(item, after:self.audioPlayer.items().last)
}
self.isRebuildingQueue = false
}
seekInCurrentTrack(to: to, playbackSession: playbackSession)
@@ -460,10 +466,14 @@ class AudioPlayer: NSObject {
let playerItems = self.allPlayerItems[indexOfSeek..<self.allPlayerItems.count]
DispatchQueue.runOnMainQueue {
// Let observers know we're rebuilding the queue
// prevents race conditions on stopping sessions if queue is empty.
self.isRebuildingQueue = true
self.audioPlayer.removeAllItems()
for item in Array(playerItems) {
self.audioPlayer.insert(item, after:self.audioPlayer.items().last)
}
self.isRebuildingQueue = false
}
seekInCurrentTrack(to: to, playbackSession: playbackSession)
@@ -796,6 +806,10 @@ class AudioPlayer: NSObject {
logger.log("WARNING: Item ended")
if audioPlayer.currentItem == nil {
// if the queue is rebuilding, we expect the current item may be nil
if self.isRebuildingQueue {
return
}
logger.log("Player ended or next item is nil, marking ended")
self.markAudioSessionAs(active: false)
}