Files
aryx/src/renderer/components/quick-prompt/ModelSelector.tsx
T
David KayaandCopilot fdfa6f3046 fix: remove shadow causing gradient rectangle and add keyboard navigation to quick prompt model picker
Remove shadow-2xl shadow-black/50 from the ModelSelector dropdown. On
transparent Electron windows (Windows), box-shadows paint onto the
transparent canvas and create a visible rectangle behind the UI — the
panel itself already avoided this with a comment explaining why.

Add full arrow-key navigation to the model picker listbox: ArrowUp/Down
cycle through options, Enter/Space selects, Home/End jump to extremes,
Escape closes. The container auto-focuses on mount so keyboard input
works immediately after opening via Tab+Enter. Mouse hover also syncs
the focused index for consistent visual feedback.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-04-15 06:57:10 +02:00

266 lines
9.7 KiB
TypeScript

import { useCallback, useEffect, useRef, useMemo, useState } from 'react';
import { Check, Brain } from 'lucide-react';
import { ProviderIcon } from '@renderer/components/ProviderIcons';
import type { ModelDefinition, ModelProvider } from '@shared/domain/models';
import { providerMeta } from '@shared/domain/models';
import type { ReasoningEffort } from '@shared/domain/workflow';
interface ModelSelectorProps {
models: ReadonlyArray<ModelDefinition>;
selectedModelId?: string;
selectedReasoning?: ReasoningEffort;
onSelect: (model: ModelDefinition) => void;
onReasoningChange: (effort: ReasoningEffort | undefined) => void;
onClose: () => void;
}
const reasoningLevels: { value: ReasoningEffort; label: string; description: string }[] = [
{ value: 'low', label: 'Low', description: 'Fast, concise' },
{ value: 'medium', label: 'Med', description: 'Balanced' },
{ value: 'high', label: 'High', description: 'Thorough' },
{ value: 'xhigh', label: 'Max', description: 'Exhaustive' },
];
interface ProviderGroup {
provider: ModelProvider | 'other';
label: string;
models: ModelDefinition[];
}
export function ModelSelector({
models,
selectedModelId,
selectedReasoning,
onSelect,
onReasoningChange,
onClose,
}: ModelSelectorProps) {
const containerRef = useRef<HTMLDivElement>(null);
const flatModels = useMemo(() => [...models], [models]);
const initialIndex = flatModels.findIndex((m) => m.id === selectedModelId);
const [focusedIndex, setFocusedIndex] = useState(initialIndex >= 0 ? initialIndex : 0);
const optionRefs = useRef<Map<number, HTMLButtonElement>>(new Map());
// Scroll the focused option into view whenever it changes
useEffect(() => {
optionRefs.current.get(focusedIndex)?.scrollIntoView({ block: 'nearest' });
}, [focusedIndex]);
const handleKeyDown = useCallback(
(e: React.KeyboardEvent) => {
switch (e.key) {
case 'ArrowDown': {
e.preventDefault();
setFocusedIndex((prev) => (prev + 1) % flatModels.length);
break;
}
case 'ArrowUp': {
e.preventDefault();
setFocusedIndex((prev) => (prev - 1 + flatModels.length) % flatModels.length);
break;
}
case 'Home': {
e.preventDefault();
setFocusedIndex(0);
break;
}
case 'End': {
e.preventDefault();
setFocusedIndex(flatModels.length - 1);
break;
}
case 'Enter':
case ' ': {
e.preventDefault();
const model = flatModels[focusedIndex];
if (model) onSelect(model);
break;
}
case 'Escape': {
e.stopPropagation();
onClose();
break;
}
}
},
[flatModels, focusedIndex, onSelect, onClose],
);
useEffect(() => {
const handleClickOutside = (e: MouseEvent) => {
if (containerRef.current && !containerRef.current.contains(e.target as Node)) {
onClose();
}
};
document.addEventListener('mousedown', handleClickOutside);
return () => {
document.removeEventListener('mousedown', handleClickOutside);
};
}, [onClose]);
// Focus the container on mount so keyboard events are captured immediately
useEffect(() => {
containerRef.current?.focus();
}, []);
const selectedModel = models.find((m) => m.id === selectedModelId);
const supportedEfforts = selectedModel?.supportedReasoningEfforts;
// Group models by provider
const groups = useMemo((): ProviderGroup[] => {
const providerOrder = providerMeta.map((p) => p.id);
const providerLabels = new Map(providerMeta.map((p) => [p.id, p.label]));
const grouped = new Map<string, ModelDefinition[]>();
for (const model of models) {
const key = model.provider ?? 'other';
const list = grouped.get(key) ?? [];
list.push(model);
grouped.set(key, list);
}
const result: ProviderGroup[] = [];
for (const providerId of providerOrder) {
const providerModels = grouped.get(providerId);
if (providerModels) {
result.push({
provider: providerId,
label: providerLabels.get(providerId) ?? providerId,
models: providerModels,
});
}
}
// Any models without a known provider
const other = grouped.get('other');
if (other) {
result.push({ provider: 'other', label: 'Other', models: other });
}
return result;
}, [models]);
// Build a flat index for each model so we can map group-based rendering
// back to the flat focusedIndex.
let flatIndex = -1;
return (
<div
ref={containerRef}
className="qp-dropdown-enter absolute top-full left-3 right-3 z-10 mt-1 overflow-hidden rounded-xl border border-[var(--color-border)] bg-[var(--color-surface-1)] outline-none"
role="listbox"
aria-label="Select model"
aria-activedescendant={flatModels[focusedIndex] ? `model-option-${flatModels[focusedIndex].id}` : undefined}
tabIndex={0}
onKeyDown={handleKeyDown}
>
{/* Model list — grouped by provider */}
<div className="max-h-[280px] overflow-y-auto overscroll-contain p-1.5">
{groups.map((group, gi) => (
<div key={group.provider}>
{gi > 0 && <div className="mx-2 my-1 border-t border-[var(--color-border-subtle)]/50" />}
{/* Provider header */}
<div className="flex items-center gap-1.5 px-2.5 pt-2 pb-1">
{group.provider !== 'other' && (
<ProviderIcon provider={group.provider} className="size-3" />
)}
<span className="text-[10px] font-semibold tracking-wider text-[var(--color-text-muted)] uppercase">
{group.label}
</span>
</div>
{/* Models in this provider group */}
{group.models.map((model) => {
flatIndex++;
const modelIndex = flatIndex;
const isSelected = model.id === selectedModelId;
const isFocused = modelIndex === focusedIndex;
const tierLabel = model.tier === 'premium' ? 'PRO' : model.tier === 'fast' ? 'FAST' : undefined;
const tierColor = model.tier === 'premium'
? 'text-amber-400 bg-amber-400/10'
: model.tier === 'fast'
? 'text-emerald-400 bg-emerald-400/10'
: '';
return (
<button
key={model.id}
id={`model-option-${model.id}`}
ref={(el) => {
if (el) optionRefs.current.set(modelIndex, el);
else optionRefs.current.delete(modelIndex);
}}
onClick={() => onSelect(model)}
onMouseEnter={() => setFocusedIndex(modelIndex)}
className={`flex w-full items-center gap-2 rounded-lg px-3 py-[7px] text-left transition-colors ${
isFocused
? 'bg-[var(--color-surface-2)] text-[var(--color-text-primary)]'
: isSelected
? 'bg-[var(--color-accent-muted)] text-[var(--color-text-primary)]'
: 'text-[var(--color-text-secondary)]'
}`}
type="button"
role="option"
aria-selected={isSelected}
tabIndex={-1}
>
<span className="flex-1 truncate text-[12px] font-medium">{model.name}</span>
{tierLabel && (
<span className={`rounded-[4px] px-1.5 py-px text-[8px] font-bold tracking-wider ${tierColor}`}>
{tierLabel}
</span>
)}
{model.supportedReasoningEfforts?.length ? (
<Brain className="size-3 flex-none text-[var(--color-text-muted)]/60" aria-label="Supports reasoning" />
) : null}
{isSelected && <Check className="size-3.5 flex-none text-[var(--color-accent)]" />}
</button>
);
})}
</div>
))}
</div>
{/* Reasoning effort — only shown when selected model supports it */}
{supportedEfforts && supportedEfforts.length > 0 && (
<div className="border-t border-[var(--color-border-subtle)] px-3 py-2.5">
<div className="mb-2 flex items-center gap-1.5">
<Brain className="size-3 text-[var(--color-text-muted)]" />
<span className="text-[10px] font-semibold tracking-wider text-[var(--color-text-muted)] uppercase">
Reasoning Effort
</span>
</div>
<div className="flex gap-1">
{reasoningLevels
.filter((lvl) => supportedEfforts.includes(lvl.value))
.map((lvl) => {
const isActive = selectedReasoning === lvl.value;
return (
<button
key={lvl.value}
onClick={() => onReasoningChange(isActive ? undefined : lvl.value)}
className={`group flex-1 rounded-lg py-1.5 text-center transition-all ${
isActive
? 'bg-[var(--color-accent)] text-white shadow-md shadow-[var(--color-accent)]/20'
: 'bg-[var(--color-surface-2)] text-[var(--color-text-muted)] hover:bg-[var(--color-surface-3)] hover:text-[var(--color-text-secondary)]'
}`}
type="button"
title={lvl.description}
>
<span className="text-[11px] font-semibold">{lvl.label}</span>
</button>
);
})}
</div>
</div>
)}
</div>
);
}