1.4.11

CHANGELOG.md

@@ -1,3 +1,11 @@
+# 1.4.11 (18 April 2021)
+- [#604](https://github.com/WireMock-Net/WireMock.Net/pull/604) - Fix match logic for exact bytearray contributed by [StefH](https://github.com/StefH)
+- [#601](https://github.com/WireMock-Net/WireMock.Net/issues/601) - Exact byte array request matching fails on specific byte arrays [bug]
+
+# 1.4.10 (15 April 2021)
+- [#603](https://github.com/WireMock-Net/WireMock.Net/pull/603) - Fix callback with Headers [bug] contributed by [StefH](https://github.com/StefH)
+- [#602](https://github.com/WireMock-Net/WireMock.Net/issues/602) - Header not being returned when set in WithCallback [bug]
+
 # 1.4.9 (31 March 2021)
 - [#600](https://github.com/WireMock-Net/WireMock.Net/pull/600) - WithProxy() should save the new mapping [bug] contributed by [StefH](https://github.com/StefH)
 

Directory.Build.props

@@ -4,7 +4,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <VersionPrefix>1.4.9</VersionPrefix>
+    <VersionPrefix>1.4.11</VersionPrefix>
     <PackageReleaseNotes>See CHANGELOG.md</PackageReleaseNotes>
     <PackageIconUrl>https://raw.githubusercontent.com/WireMock-Net/WireMock.Net/master/WireMock.Net-Logo.png</PackageIconUrl>
     <PackageProjectUrl>https://github.com/WireMock-Net/WireMock.Net</PackageProjectUrl>

GitHubReleaseNotes.txt

@@ -1,3 +1,3 @@
 https://github.com/StefH/GitHubReleaseNotes
 
-GitHubReleaseNotes --output CHANGELOG.md --skip-empty-releases --exclude-labels question invalid doc --version 1.4.9
+GitHubReleaseNotes --output CHANGELOG.md --skip-empty-releases --exclude-labels question invalid doc --version 1.4.11

src/WireMock.Net/Matchers/Request/RequestMessageBodyMatcher.cs

@@ -1,185 +1,195 @@
-using JetBrains.Annotations;
-using System;
-using System.Linq;
-using WireMock.Types;
+using JetBrains.Annotations;
+using System;
+using System.Linq;
+using WireMock.Types;
 using WireMock.Util;
-using WireMock.Validation;
-
-namespace WireMock.Matchers.Request
-{
-    /// <summary>
-    /// The request body matcher.
-    /// </summary>
-    public class RequestMessageBodyMatcher : IRequestMatcher
-    {
-        /// <summary>
-        /// The body function
-        /// </summary>
-        public Func<string, bool> Func { get; }
-
-        /// <summary>
-        /// The body data function for byte[]
-        /// </summary>
-        public Func<byte[], bool> DataFunc { get; }
-
-        /// <summary>
-        /// The body data function for json
-        /// </summary>
-        public Func<object, bool> JsonFunc { get; }
-
-        /// <summary>
-        /// The body data function for BodyData
-        /// </summary>
-        public Func<IBodyData, bool> BodyDataFunc { get; }
-
-        /// <summary>
-        /// The matchers.
-        /// </summary>
-        public IMatcher[] Matchers { get; }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="matchBehaviour">The match behaviour.</param>
-        /// <param name="body">The body.</param>
-        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] string body) : this(new[] { new WildcardMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
-        {
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="matchBehaviour">The match behaviour.</param>
-        /// <param name="body">The body.</param>
-        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] byte[] body) : this(new[] { new ExactObjectMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
-        {
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="matchBehaviour">The match behaviour.</param>
-        /// <param name="body">The body.</param>
-        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] object body) : this(new[] { new ExactObjectMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
-        {
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="func">The function.</param>
-        public RequestMessageBodyMatcher([NotNull] Func<string, bool> func)
-        {
-            Check.NotNull(func, nameof(func));
-            Func = func;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="func">The function.</param>
-        public RequestMessageBodyMatcher([NotNull] Func<byte[], bool> func)
-        {
-            Check.NotNull(func, nameof(func));
-            DataFunc = func;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="func">The function.</param>
-        public RequestMessageBodyMatcher([NotNull] Func<object, bool> func)
-        {
-            Check.NotNull(func, nameof(func));
-            JsonFunc = func;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="func">The function.</param>
-        public RequestMessageBodyMatcher([NotNull] Func<IBodyData, bool> func)
-        {
-            Check.NotNull(func, nameof(func));
-            BodyDataFunc = func;
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
-        /// </summary>
-        /// <param name="matchers">The matchers.</param>
-        public RequestMessageBodyMatcher([NotNull] params IMatcher[] matchers)
-        {
-            Check.NotNull(matchers, nameof(matchers));
-            Matchers = matchers;
-        }
-
-        /// <see cref="IRequestMatcher.GetMatchingScore"/>
-        public double GetMatchingScore(IRequestMessage requestMessage, RequestMatchResult requestMatchResult)
-        {
-            double score = CalculateMatchScore(requestMessage);
-            return requestMatchResult.AddScore(GetType(), score);
-        }
-
-        private double CalculateMatchScore(IRequestMessage requestMessage, IMatcher matcher)
-        {
-            // Check if the matcher is a IObjectMatcher
-            if (matcher is IObjectMatcher objectMatcher)
-            {
-                // If the body is a JSON object, try to match.
-                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Json)
-                {
-                    return objectMatcher.IsMatch(requestMessage.BodyData.BodyAsJson);
-                }
-
-                // If the body is a byte array, try to match.
-                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Bytes)
-                {
-                    return objectMatcher.IsMatch(requestMessage.BodyData.BodyAsBytes);
-                }
-            }
-
-            // Check if the matcher is a IStringMatcher
-            if (matcher is IStringMatcher stringMatcher)
-            {
-                // If the body is a Json or a String, use the BodyAsString to match on.
-                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Json || requestMessage?.BodyData?.DetectedBodyType == BodyType.String)
-                {
-                    return stringMatcher.IsMatch(requestMessage.BodyData.BodyAsString);
-                }
-            }
-
-            return MatchScores.Mismatch;
-        }
-
-        private double CalculateMatchScore(IRequestMessage requestMessage)
-        {
-            if (Matchers != null && Matchers.Any())
-            {
-                return Matchers.Max(matcher => CalculateMatchScore(requestMessage, matcher));
-            }
-
-            if (Func != null)
-            {
-                return MatchScores.ToScore(Func(requestMessage?.BodyData?.BodyAsString));
-            }
-
-            if (JsonFunc != null)
-            {
-                return MatchScores.ToScore(JsonFunc(requestMessage?.BodyData?.BodyAsJson));
-            }
-
-            if (DataFunc != null)
-            {
-                return MatchScores.ToScore(DataFunc(requestMessage?.BodyData?.BodyAsBytes));
-            }
-
-            if (BodyDataFunc != null)
-            {
-                return MatchScores.ToScore(BodyDataFunc(requestMessage?.BodyData));
-            }
-
-            return MatchScores.Mismatch;
-        }
-    }
+using WireMock.Validation;
+
+namespace WireMock.Matchers.Request
+{
+    /// <summary>
+    /// The request body matcher.
+    /// </summary>
+    public class RequestMessageBodyMatcher : IRequestMatcher
+    {
+        /// <summary>
+        /// The body function
+        /// </summary>
+        public Func<string, bool> Func { get; }
+
+        /// <summary>
+        /// The body data function for byte[]
+        /// </summary>
+        public Func<byte[], bool> DataFunc { get; }
+
+        /// <summary>
+        /// The body data function for json
+        /// </summary>
+        public Func<object, bool> JsonFunc { get; }
+
+        /// <summary>
+        /// The body data function for BodyData
+        /// </summary>
+        public Func<IBodyData, bool> BodyDataFunc { get; }
+
+        /// <summary>
+        /// The matchers.
+        /// </summary>
+        public IMatcher[] Matchers { get; }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="matchBehaviour">The match behaviour.</param>
+        /// <param name="body">The body.</param>
+        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] string body) : this(new[] { new WildcardMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="matchBehaviour">The match behaviour.</param>
+        /// <param name="body">The body.</param>
+        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] byte[] body) : this(new[] { new ExactObjectMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="matchBehaviour">The match behaviour.</param>
+        /// <param name="body">The body.</param>
+        public RequestMessageBodyMatcher(MatchBehaviour matchBehaviour, [NotNull] object body) : this(new[] { new ExactObjectMatcher(matchBehaviour, body) }.Cast<IMatcher>().ToArray())
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="func">The function.</param>
+        public RequestMessageBodyMatcher([NotNull] Func<string, bool> func)
+        {
+            Check.NotNull(func, nameof(func));
+            Func = func;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="func">The function.</param>
+        public RequestMessageBodyMatcher([NotNull] Func<byte[], bool> func)
+        {
+            Check.NotNull(func, nameof(func));
+            DataFunc = func;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="func">The function.</param>
+        public RequestMessageBodyMatcher([NotNull] Func<object, bool> func)
+        {
+            Check.NotNull(func, nameof(func));
+            JsonFunc = func;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="func">The function.</param>
+        public RequestMessageBodyMatcher([NotNull] Func<IBodyData, bool> func)
+        {
+            Check.NotNull(func, nameof(func));
+            BodyDataFunc = func;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RequestMessageBodyMatcher"/> class.
+        /// </summary>
+        /// <param name="matchers">The matchers.</param>
+        public RequestMessageBodyMatcher([NotNull] params IMatcher[] matchers)
+        {
+            Check.NotNull(matchers, nameof(matchers));
+            Matchers = matchers;
+        }
+
+        /// <see cref="IRequestMatcher.GetMatchingScore"/>
+        public double GetMatchingScore(IRequestMessage requestMessage, RequestMatchResult requestMatchResult)
+        {
+            double score = CalculateMatchScore(requestMessage);
+            return requestMatchResult.AddScore(GetType(), score);
+        }
+
+        private double CalculateMatchScore(IRequestMessage requestMessage, IMatcher matcher)
+        {
+            if (matcher is ExactObjectMatcher exactObjectMatcher)
+            {
+                // If the body is a byte array, try to match.
+                var detectedBodyType = requestMessage?.BodyData?.DetectedBodyType;
+                if (detectedBodyType == BodyType.Bytes || detectedBodyType == BodyType.String)
+                {
+                    return exactObjectMatcher.IsMatch(requestMessage.BodyData.BodyAsBytes);
+                }
+            }
+
+            // Check if the matcher is a IObjectMatcher
+            if (matcher is IObjectMatcher objectMatcher)
+            {
+                // If the body is a JSON object, try to match.
+                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Json)
+                {
+                    return objectMatcher.IsMatch(requestMessage.BodyData.BodyAsJson);
+                }
+
+                // If the body is a byte array, try to match.
+                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Bytes)
+                {
+                    return objectMatcher.IsMatch(requestMessage.BodyData.BodyAsBytes);
+                }
+            }
+
+            // Check if the matcher is a IStringMatcher
+            if (matcher is IStringMatcher stringMatcher)
+            {
+                // If the body is a Json or a String, use the BodyAsString to match on.
+                if (requestMessage?.BodyData?.DetectedBodyType == BodyType.Json || requestMessage?.BodyData?.DetectedBodyType == BodyType.String)
+                {
+                    return stringMatcher.IsMatch(requestMessage.BodyData.BodyAsString);
+                }
+            }
+
+            return MatchScores.Mismatch;
+        }
+
+        private double CalculateMatchScore(IRequestMessage requestMessage)
+        {
+            if (Matchers != null && Matchers.Any())
+            {
+                return Matchers.Max(matcher => CalculateMatchScore(requestMessage, matcher));
+            }
+
+            if (Func != null)
+            {
+                return MatchScores.ToScore(Func(requestMessage?.BodyData?.BodyAsString));
+            }
+
+            if (JsonFunc != null)
+            {
+                return MatchScores.ToScore(JsonFunc(requestMessage?.BodyData?.BodyAsJson));
+            }
+
+            if (DataFunc != null)
+            {
+                return MatchScores.ToScore(DataFunc(requestMessage?.BodyData?.BodyAsBytes));
+            }
+
+            if (BodyDataFunc != null)
+            {
+                return MatchScores.ToScore(BodyDataFunc(requestMessage?.BodyData));
+            }
+
+            return MatchScores.Mismatch;
+        }
+    }
 }

src/WireMock.Net/ResponseBuilders/Response.cs

@@ -392,7 +392,7 @@ namespace WireMock.ResponseBuilders
                 }
 
                 // Copy Headers from ResponseMessage (if defined)
-                if (ResponseMessage.Headers != null)
+                if (ResponseMessage.Headers?.Count > 0)
                 {
                     responseMessage.Headers = ResponseMessage.Headers;
                 }

test/WireMock.Net.Tests/RequestMatchers/RequestMessageBodyMatcherTests.cs

@@ -209,13 +209,15 @@ namespace WireMock.Net.Tests.RequestMatchers
             Check.That(score).IsEqualTo(1.0d);
         }
 
-        [Fact]
-        public void RequestMessageBodyMatcher_GetMatchingScore_BodyAsBytes_IObjectMatcher()
+        [Theory]
+        [InlineData(new byte[] { 1 })]
+        [InlineData(new byte[] { 48 })]
+        public void RequestMessageBodyMatcher_GetMatchingScore_BodyAsBytes_IObjectMatcher(byte[] bytes)
         {
             // Assign
             var body = new BodyData
             {
-                BodyAsBytes = new byte[] { 1 },
+                BodyAsBytes = bytes,
                 DetectedBodyType = BodyType.Bytes
             };
             var objectMatcherMock = new Mock<IObjectMatcher>();

test/WireMock.Net.Tests/RequestWithBodyTests.cs

@@ -2,6 +2,7 @@
 using NFluent;
 using System;
 using System.Text;
+using FluentAssertions;
 using WireMock.Matchers;
 using WireMock.Matchers.Request;
 using WireMock.Models;
@@ -307,17 +308,20 @@ namespace WireMock.Net.Tests
             Check.That(requestBuilder.GetMatchingScore(request, requestMatchResult)).IsEqualTo(1.0);
         }
 
-        [Fact]
-        public void Request_WithBodyAsBytes_ExactObjectMatcher_true()
+        [Theory]
+        [InlineData(new byte[] { 1 }, BodyType.Bytes)]
+        [InlineData(new byte[] { 48, 49, 50 }, BodyType.Bytes)]
+        [InlineData(new byte[] { 48, 49, 50 }, BodyType.String)]
+        public void Request_WithBodyAsBytes_ExactObjectMatcher_true(byte[] bytes, BodyType detectedBodyType)
         {
             // Assign
-            byte[] body = { 123 };
+            byte[] body = bytes;
             var requestBuilder = Request.Create().UsingAnyMethod().WithBody(body);
 
             var bodyData = new BodyData
             {
-                BodyAsBytes = new byte[] { 123 },
-                DetectedBodyType = BodyType.Bytes
+                BodyAsBytes = bytes,
+                DetectedBodyType = detectedBodyType
             };
 
             // Act
@@ -325,7 +329,7 @@ namespace WireMock.Net.Tests
 
             // Assert
             var requestMatchResult = new RequestMatchResult();
-            Check.That(requestBuilder.GetMatchingScore(request, requestMatchResult)).IsEqualTo(1.0);
+            requestBuilder.GetMatchingScore(request, requestMatchResult).Should().Be(1.0);
         }
     }
 }

test/WireMock.Net.Tests/ResponseBuilders/ResponseWithCallbackTests.cs

@@ -82,7 +82,37 @@ namespace WireMock.Net.Tests.ResponseBuilders
         }
 
         [Fact]
-        public async Task Response_WithCallback_And_WithStatusCode_And_WithHeader()
+        public async Task Response_WithCallback_ShouldUseStatusCodeAndHeaderInTheCallback()
+        {
+            // Assign
+            var header = "X-UserId";
+            var requestMessage = new RequestMessage(new UrlDetails("http://localhost/foo"), "GET", "::1");
+            var responseBuilder = Response.Create()
+                .WithCallback(request => new ResponseMessage
+                {
+                    BodyData = new BodyData
+                    {
+                        DetectedBodyType = BodyType.String,
+                        BodyAsString = request.Path + "Bar"
+                    },
+                    StatusCode = HttpStatusCode.Accepted,
+                    Headers = new Dictionary<string, WireMockList<string>>
+                    {
+                        { header, new WireMockList<string>("Stef") }
+                    }
+                });
+
+            // Act
+            var response = await responseBuilder.ProvideResponseAsync(requestMessage, _settings);
+
+            // Assert
+            response.Message.BodyData.BodyAsString.Should().Be("/fooBar");
+            response.Message.StatusCode.Should().Be(HttpStatusCode.Accepted);
+            response.Message.Headers[header].Should().ContainSingle("Stef");
+        }
+
+        [Fact]
+        public async Task Response_WithCallback_And_Additional_WithStatusCode_And_WithHeader_ShouldUseAdditional()
         {
             // Assign
             var header = "X-UserId";