starred/SwiftUI
1
0
Fork 0
mirror of https://github.com/ivanvorobei/SwiftUI.git synced 2026-09-03 16:37:31 +02:00
Code Issues 8 Packages Projects Releases Wiki Activity

[PR #20] [MERGED] Workaround for beta 5+. #30

New Issue
Closed
opened 2025-12-29 04:20:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 04:20:16 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/ivanvorobei/SwiftUI/pull/20
Author: @johnno1962
Created: 8/29/2019
Status: ✅ Merged
Merged: 8/29/2019
Merged by: @ivanvorobei

Base: master ← Head: xcode-11-beta7

📝 Commits (2)

  • a018d08 Workaround for beta 5+.
  • 3a29b6c Fix WWDC paths in Player project

📊 Changes

3 files changed (+6 additions, -5 deletions)

View changed files

📝 Other Projects/WWDCPlayer/WWDCPlayer.xcodeproj/project.pbxproj (+4 -4)
📝 Other Projects/WWDCPlayer/WWDCPlayer/MainView.swift (+1 -1)
📝 Other Projects/WWDCPlayer/WWDCPlayer/VideoRow.swift (+1 -0)

📄 Description

There was a slight regression in beta5 which meant the isFavourite star in the WWDC Player example stopped updating. This workaround fixes this for now. I have a radar open.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ivanvorobei/SwiftUI/pull/20 **Author:** [@johnno1962](https://github.com/johnno1962) **Created:** 8/29/2019 **Status:** ✅ Merged **Merged:** 8/29/2019 **Merged by:** [@ivanvorobei](https://github.com/ivanvorobei) **Base:** `master` ← **Head:** `xcode-11-beta7` --- ### 📝 Commits (2) - [`a018d08`](https://github.com/ivanvorobei/SwiftUI/commit/a018d0806d8c9711d4324e1e767b317ccab0f09a) Workaround for beta 5+. - [`3a29b6c`](https://github.com/ivanvorobei/SwiftUI/commit/3a29b6cd578105cec3f853725a4a7bd0cd3d4ec4) Fix WWDC paths in Player project ### 📊 Changes **3 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Other Projects/WWDCPlayer/WWDCPlayer.xcodeproj/project.pbxproj` (+4 -4) 📝 `Other Projects/WWDCPlayer/WWDCPlayer/MainView.swift` (+1 -1) 📝 `Other Projects/WWDCPlayer/WWDCPlayer/VideoRow.swift` (+1 -0) </details> ### 📄 Description There was a slight regression in beta5 which meant the isFavourite star in the WWDC Player example stopped updating. This workaround fixes this for now. I have a radar open. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 04:20:16 +01:00
adam closed this issue 2025-12-29 04:20:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/SwiftUI#30