[PR #8] [MERGED] Combine examples #20

New Issue

Closed

opened 2025-12-29 04:20:14 +01:00 by adam · 0 comments

adam commented 2025-12-29 04:20:14 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/ivanvorobei/SwiftUI/pull/8
Author: @johnno1962
Created: 7/10/2019
Status: ✅ Merged
Merged: 7/10/2019
Merged by: @ivanvorobei

Base: master ← Head: xcode-11-beta3

---

📝 Commits (1)

• 5722939 Combine examples

📊 Changes

13 files changed (+273 additions, -90 deletions)

View changed files

📝 Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/FoundationExtensions.swift (+45 -22)
📝 Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/SceneDelegate.swift (+6 -0)
📝 Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/SearchUserViewModel.swift (+4 -3)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI.xcodeproj/project.pbxproj (+16 -0)
➕ Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Extension/Publisher.Extension.swift (+36 -0)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Extension/URLSession.Combine.swift (+10 -28)
➕ Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/AnySubscription.swift (+25 -0)
➕ Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/ErrorResponse.swift (+13 -0)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/RepositoryAPI.swift (+22 -7)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI/SceneDelegate.swift (+6 -6)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/RepositoryListView.swift (+32 -8)
📝 Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/RepositoryListViewModel.swift (+37 -16)
➕ Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/WebView.swift (+21 -0)

📄 Description

Hi,

Any finally here are the Combine examples fixed up for beta3.
Thanks a lot for setting this repo up. It's been very informative.

John

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ivanvorobei/SwiftUI/pull/8 **Author:** [@johnno1962](https://github.com/johnno1962) **Created:** 7/10/2019 **Status:** ✅ Merged **Merged:** 7/10/2019 **Merged by:** [@ivanvorobei](https://github.com/ivanvorobei) **Base:** `master` ← **Head:** `xcode-11-beta3` --- ### 📝 Commits (1) - [`5722939`](https://github.com/ivanvorobei/SwiftUI/commit/57229399265d82acb136763cff01fd2e7893dcf9) Combine examples ### 📊 Changes **13 files changed** (+273 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/FoundationExtensions.swift` (+45 -22) 📝 `Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/SceneDelegate.swift` (+6 -0) 📝 `Other Projects/Combine using GitHub API/SwiftUI-Combine-Example/SearchUserViewModel.swift` (+4 -3) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI.xcodeproj/project.pbxproj` (+16 -0) ➕ `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Extension/Publisher.Extension.swift` (+36 -0) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Extension/URLSession.Combine.swift` (+10 -28) ➕ `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/AnySubscription.swift` (+25 -0) ➕ `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/ErrorResponse.swift` (+13 -0) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/Model/RepositoryAPI.swift` (+22 -7) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/SceneDelegate.swift` (+6 -6) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/RepositoryListView.swift` (+32 -8) 📝 `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/RepositoryListViewModel.swift` (+37 -16) ➕ `Other Projects/GitHub Search/GitHubSearchWithSwiftUI/View/WebView.swift` (+21 -0) </details> ### 📄 Description Hi, Any finally here are the Combine examples fixed up for beta3. Thanks a lot for setting this repo up. It's been very informative. John --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 04:20:14 +01:00

adam closed this issue 2025-12-29 04:20:14 +01:00

adam referenced this issue 2025-12-29 04:20:16 +01:00

[PR #20] [MERGED] Workaround for beta 5+. #30

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

No results found.

Labels

Clear labels

bug

bug

bug

enhancement

pull-request

Mirrored from GitHub Pull Request

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/SwiftUI#20