starred/Memola
1
0
Fork 0
mirror of https://github.com/dscyrescotti/Memola.git synced 2026-01-14 05:03:24 +01:00
Code Issues 5 Packages Projects Releases 3 Wiki Activity

[PR #52] [MERGED] Add option for line grid on canvas view #63

New Issue
Closed
opened 2025-12-29 05:19:23 +01:00 by adam · 0 comments
adam commented 2025-12-29 05:19:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/52
Author: @dscyrescotti
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/grid-option

📝 Commits (3)

📊 Changes

21 files changed (+280 additions, -51 deletions)

View changed files

📝 Memola.xcodeproj/project.pbxproj (+28 -8)
➕ Memola/Canvas/Buffers/Vertices/LineGridVertex.swift (+13 -0)
📝 Memola/Canvas/Buffers/Vertices/PointGridVertex.swift (+3 -3)
📝 Memola/Canvas/Contexts/GraphicContext.swift (+0 -3)
➕ Memola/Canvas/Contexts/LineGridContext.swift (+45 -0)
📝 Memola/Canvas/Contexts/PointGridContext.swift (+6 -9)
📝 Memola/Canvas/Contexts/ViewPortContext.swift (+0 -3)
📝 Memola/Canvas/Core/Canvas.swift (+33 -4)
📝 Memola/Canvas/Core/PipelineStates.swift (+25 -4)
➕ Memola/Canvas/Grid/GridMode.swift (+38 -0)
📝 Memola/Canvas/RenderPasses/ViewPortRenderPass.swift (+16 -5)
📝 Memola/Canvas/Shaders/Grid.metal (+28 -7)
📝 Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift (+13 -2)
📝 Memola/Features/Memo/Memo/MemoView.swift (+1 -1)
📝 Memola/Features/Memo/Toolbar/Toolbar.swift (+27 -1)
📝 Memola/Features/Memos/MemosView.swift (+1 -0)
📝 Memola/Persistence/Objects/CanvasObject.swift (+1 -0)
📝 Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/Contents.json (+1 -1)
➕ Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/point-texture 1.png (+0 -0)
➖ Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/point-texture.png (+0 -0)

...and 1 more files

📄 Description

Description

This PR add line grid mode option along with grid mode picker button right beside the history control button.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/52 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/grid-option` --- ### 📝 Commits (3) - [`32af33f`](https://github.com/dscyrescotti/Memola/commit/32af33f617a4a14eafedf00c5db2c41b98e5521d) feat: remove guard condition - [`de71b56`](https://github.com/dscyrescotti/Memola/commit/de71b567acecc74e2cc24dd06a7a329c861adce9) feat: add grid option - [`f104416`](https://github.com/dscyrescotti/Memola/commit/f104416fe48ad1d725f726be741d2772155f27ee) feat: update point texture ### 📊 Changes **21 files changed** (+280 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Memola.xcodeproj/project.pbxproj` (+28 -8) ➕ `Memola/Canvas/Buffers/Vertices/LineGridVertex.swift` (+13 -0) 📝 `Memola/Canvas/Buffers/Vertices/PointGridVertex.swift` (+3 -3) 📝 `Memola/Canvas/Contexts/GraphicContext.swift` (+0 -3) ➕ `Memola/Canvas/Contexts/LineGridContext.swift` (+45 -0) 📝 `Memola/Canvas/Contexts/PointGridContext.swift` (+6 -9) 📝 `Memola/Canvas/Contexts/ViewPortContext.swift` (+0 -3) 📝 `Memola/Canvas/Core/Canvas.swift` (+33 -4) 📝 `Memola/Canvas/Core/PipelineStates.swift` (+25 -4) ➕ `Memola/Canvas/Grid/GridMode.swift` (+38 -0) 📝 `Memola/Canvas/RenderPasses/ViewPortRenderPass.swift` (+16 -5) 📝 `Memola/Canvas/Shaders/Grid.metal` (+28 -7) 📝 `Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift` (+13 -2) 📝 `Memola/Features/Memo/Memo/MemoView.swift` (+1 -1) 📝 `Memola/Features/Memo/Toolbar/Toolbar.swift` (+27 -1) 📝 `Memola/Features/Memos/MemosView.swift` (+1 -0) 📝 `Memola/Persistence/Objects/CanvasObject.swift` (+1 -0) 📝 `Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/Contents.json` (+1 -1) ➕ `Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/point-texture 1.png` (+0 -0) ➖ `Memola/Resources/Assets/Assets.xcassets/textures/point-texture.textureset/Universal.mipmapset/point-texture.png` (+0 -0) _...and 1 more files_ </details> ### 📄 Description ### Description This PR add line grid mode option along with grid mode picker button right beside the history control button. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 05:19:23 +01:00
adam closed this issue 2025-12-29 05:19:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Memola#63
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?