starred/Memola
1
0
Fork 0
mirror of https://github.com/dscyrescotti/Memola.git synced 2026-08-10 13:58:36 +02:00
Code Issues 5 Packages Projects Releases 3 Wiki Activity

[PR #36] [MERGED] Use indexed rendering to reduce memory bandwidth #52

New Issue
Closed
opened 2025-12-29 05:19:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 05:19:18 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/36
Author: @dscyrescotti
Created: 5/23/2024
Status: ✅ Merged
Merged: 5/23/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/indexed-render

📝 Commits (3)

  • aa819fc feat: use indexed rendering
  • 24a9c3e feat: update pen thicknesses
  • 81fb43f bug: correct memory layout format

📊 Changes

6 files changed (+43 additions, -22 deletions)

View changed files

📝 Memola/Canvas/Geometries/Stroke/Stroke.swift (+12 -4)
📝 Memola/Canvas/RenderPasses/EraserRenderPass.swift (+5 -2)
📝 Memola/Canvas/RenderPasses/StrokeRenderPass.swift (+5 -2)
📝 Memola/Canvas/Shaders/Quad.metal (+16 -9)
📝 Memola/Canvas/Tool/Pen/PenStyles/EraserPenStyle.swift (+3 -3)
📝 Memola/Canvas/Tool/Pen/PenStyles/MarkerPenStyle.swift (+2 -2)

📄 Description

Description

This PR uses indexed rendering to reduce the size of vertex buffer for each stroke.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/36 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 5/23/2024 **Status:** ✅ Merged **Merged:** 5/23/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/indexed-render` --- ### 📝 Commits (3) - [`aa819fc`](https://github.com/dscyrescotti/Memola/commit/aa819fcdc9332ee7330d049955a3f88b94e5f47d) feat: use indexed rendering - [`24a9c3e`](https://github.com/dscyrescotti/Memola/commit/24a9c3ed5139d3514c5cfb7e0861eb51ed7e1bb8) feat: update pen thicknesses - [`81fb43f`](https://github.com/dscyrescotti/Memola/commit/81fb43f3e328bbb65ffb88706f7bc03d6ffb2026) bug: correct memory layout format ### 📊 Changes **6 files changed** (+43 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `Memola/Canvas/Geometries/Stroke/Stroke.swift` (+12 -4) 📝 `Memola/Canvas/RenderPasses/EraserRenderPass.swift` (+5 -2) 📝 `Memola/Canvas/RenderPasses/StrokeRenderPass.swift` (+5 -2) 📝 `Memola/Canvas/Shaders/Quad.metal` (+16 -9) 📝 `Memola/Canvas/Tool/Pen/PenStyles/EraserPenStyle.swift` (+3 -3) 📝 `Memola/Canvas/Tool/Pen/PenStyles/MarkerPenStyle.swift` (+2 -2) </details> ### 📄 Description ### Description This PR uses indexed rendering to reduce the size of vertex buffer for each stroke. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 05:19:18 +01:00
adam closed this issue 2025-12-29 05:19:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Memola#52