starred/CoreStore-JohnEstropia
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-09-03 08:27:16 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

[PR #243] [CLOSED] Swift 4.1, Xcode 9.3 warnings fixed #482

New Issue
Closed
opened 2025-12-29 18:27:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:27:13 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/243
Author: @DimaAvvakumov
Created: 4/3/2018
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (2)

  • 651f88c Swift 4.1 warnings fix
  • b3171f8 Protocol declaration weak removed

📊 Changes

9 files changed (+19 additions, -19 deletions)

View changed files

📝 Sources/AsynchronousDataTransaction.swift (+1 -1)
📝 Sources/AttributeProtocol.swift (+1 -1)
📝 Sources/BaseDataTransaction+Importing.swift (+2 -2)
📝 Sources/BaseDataTransaction.swift (+7 -7)
📝 Sources/CustomSchemaMappingProvider.swift (+2 -2)
📝 Sources/NSManagedObjectContext+Querying.swift (+2 -2)
📝 Sources/Relationship.swift (+2 -2)
📝 Sources/RelationshipProtocol.swift (+1 -1)
📝 Sources/SynchronousDataTransaction.swift (+1 -1)

📄 Description

I tried to remove some warnings appears after update Xcode to 9.3

  1. Swift 4.1 New: flatMap function replaced with compactMap
  2. Protocol description deny using weak statement in property declaration
  3. Cast warning from CoreStoreManagedObject to NSManagedObject

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/243 **Author:** [@DimaAvvakumov](https://github.com/DimaAvvakumov) **Created:** 4/3/2018 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`651f88c`](https://github.com/JohnEstropia/CoreStore/commit/651f88cc1b734cd9fc2c4fbd8d8ad83df916fa6d) Swift 4.1 warnings fix - [`b3171f8`](https://github.com/JohnEstropia/CoreStore/commit/b3171f8c64eb506cdf706f61b281b644cb32e1ed) Protocol declaration `weak` removed ### 📊 Changes **9 files changed** (+19 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `Sources/AsynchronousDataTransaction.swift` (+1 -1) 📝 `Sources/AttributeProtocol.swift` (+1 -1) 📝 `Sources/BaseDataTransaction+Importing.swift` (+2 -2) 📝 `Sources/BaseDataTransaction.swift` (+7 -7) 📝 `Sources/CustomSchemaMappingProvider.swift` (+2 -2) 📝 `Sources/NSManagedObjectContext+Querying.swift` (+2 -2) 📝 `Sources/Relationship.swift` (+2 -2) 📝 `Sources/RelationshipProtocol.swift` (+1 -1) 📝 `Sources/SynchronousDataTransaction.swift` (+1 -1) </details> ### 📄 Description I tried to remove some warnings appears after update Xcode to 9.3 1. Swift 4.1 New: flatMap function replaced with compactMap 2. Protocol description deny using weak statement in property declaration 3. Cast warning from CoreStoreManagedObject to NSManagedObject --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 18:27:13 +01:00
adam closed this issue 2025-12-29 18:27:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#482