Unsafe transaction changes not persisted to disk if save() called on context #243

New Issue

Closed

opened 2025-12-29 18:24:48 +01:00 by adam · 5 comments

adam commented 2025-12-29 18:24:48 +01:00

Owner

Copy Link

Copy Source

Originally created by @markst on GitHub (Nov 20, 2018).

I'm using a UnsafeDataTransaction in combination with ListMonitor which I display results in progress prior to committing saved changes.

My ListMonitor does not update with results unless I call:

try? transaction.unsafeContext().save()

However upon attempting to persist my changes such as:

transaction?.commit({ [weak self] (error) in
    if error == nil {
        self?.navigationController?.popViewController(animated: true)
    } else {
        ErrorHandler.showError(with: error?.localizedDescription ?? "Error Occured...")
    }
})

My changes are not correctly written to persisted store.

Originally created by @markst on GitHub (Nov 20, 2018). I'm using a `UnsafeDataTransaction` in combination with `ListMonitor` which I display results in progress prior to committing saved changes. My `ListMonitor` does not update with results unless I call: ```swift try? transaction.unsafeContext().save() ``` However upon attempting to persist my changes such as: ```swift transaction?.commit({ [weak self] (error) in if error == nil { self?.navigationController?.popViewController(animated: true) } else { ErrorHandler.showError(with: error?.localizedDescription ?? "Error Occured...") } }) ``` My changes are not correctly written to persisted store.

adam closed this issue 2025-12-29 18:24:48 +01:00

adam commented 2025-12-29 18:24:49 +01:00

Author

Owner

Copy Link

Copy Source

@markst commented on GitHub (Nov 20, 2018):

If I force saving on the parent context:

try? transaction?.unsafeContext().parent?.save()

The changes are correctly persisted.

@markst commented on GitHub (Nov 20, 2018): If I force saving on the parent context: ```swift try? transaction?.unsafeContext().parent?.save() ``` The changes are correctly persisted.

adam commented 2025-12-29 18:24:49 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 20, 2018):

How do you confirm that the changes are not persisted?
Do you get an error within the commit block?

@JohnEstropia commented on GitHub (Nov 20, 2018): How do you confirm that the changes are not persisted? Do you get an error within the `commit` block?

adam commented 2025-12-29 18:24:49 +01:00

Author

Owner

Copy Link

Copy Source

@markst commented on GitHub (Nov 20, 2018):

No error. I perform a fetch later on in the app's lifetime & no results are returned.

It appears due to self.hasChanges guard returning early & never breaking into saving the parent:
https://github.com/JohnEstropia/CoreStore/blob/40f458a09c0177d15ceab1561acaede2799c4f2d/Sources/NSManagedObjectContext%2BTransaction.swift#L186

@markst commented on GitHub (Nov 20, 2018): No error. I perform a fetch later on in the app's lifetime & no results are returned. It appears due to `self.hasChanges` guard returning early & never breaking into saving the parent: https://github.com/JohnEstropia/CoreStore/blob/40f458a09c0177d15ceab1561acaede2799c4f2d/Sources/NSManagedObjectContext%2BTransaction.swift#L186

adam commented 2025-12-29 18:24:50 +01:00

Author

Owner

Copy Link

Copy Source

@markst commented on GitHub (Nov 30, 2018):

@JohnEstropia
On further investigation it seems I should be using flush(). #71
This produces the desired effect with commit() correctly persisting to disk.

Is it all good to simply destroy the transaction if I changes should not be persisted?

@markst commented on GitHub (Nov 30, 2018): @JohnEstropia On further investigation it seems I should be using `flush()`. #71 This produces the desired effect with `commit()` correctly persisting to disk. Is it all good to simply destroy the transaction if I changes should not be persisted?

adam commented 2025-12-29 18:24:50 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 30, 2018):

@markst Yes, discarding the transaction will remove all unsaved changes.

@JohnEstropia commented on GitHub (Nov 30, 2018): @markst Yes, discarding the transaction will remove all unsaved changes.

adam referenced this issue 2025-12-29 18:27:13 +01:00

[PR #243] [CLOSED] Swift 4.1, Xcode 9.3 warnings fixed #482

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#243