starred/Armchair-UrbanApps
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-08-24 20:54:09 +02:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

[PR #5] [MERGED] Fixing a bug where finding the right window wouldn't work. #88

New Issue
Closed
opened 2025-12-30 00:28:05 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:28:05 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/5
Author: @plivesey
Created: 11/23/2014
Status: ✅ Merged
Merged: 11/25/2014
Merged by: @coneybeare

Base: master ← Head: master

📝 Commits (1)

  • 4e92562 Fixing a bug where finding the right window wouldn't work.

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 Source/Armchair.swift (+7 -4)

📄 Description

Now, even if you call rateApp() from a UIActionSheet, it will actually present the modal.

This logic seems to be broken currently. It searches for the right window, but never sets it to the local variable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/5 **Author:** [@plivesey](https://github.com/plivesey) **Created:** 11/23/2014 **Status:** ✅ Merged **Merged:** 11/25/2014 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4e92562`](https://github.com/UrbanApps/Armchair/commit/4e9256254783552d5a82f74d2a1be639681c2b64) Fixing a bug where finding the right window wouldn't work. ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Source/Armchair.swift` (+7 -4) </details> ### 📄 Description Now, even if you call rateApp() from a UIActionSheet, it will actually present the modal. This logic seems to be broken currently. It searches for the right window, but never sets it to the local variable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:28:05 +01:00
adam closed this issue 2025-12-30 00:28:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair-UrbanApps#88