Removing aws_iam_service_linked_role from module (#160)

CHANGELOG.md

@@ -9,12 +9,11 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
-- A useful addition (slam dunk, @self 🔥)
 - `suspended_processes` to `worker_groups` input (by @bkmeneguello)
 
 ### Changed
 
-- A subtle but thoughtful change. (Boomshakalaka, @self 🏀)
+- Remove aws_iam_service_linked_role (by @max-rocket-internet)
 - Adjust the order and correct/update the ec2 instance type info. (@chenrui333)
 
 ## [[v1.7.0](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v1.6.0...v1.7.0)] - 2018-10-09]
@@ -28,7 +27,6 @@ project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
-- A subtle but thoughtful change. (Boomshakalaka, @self 🏀)
 - fix default worker subnets not working (by @erks)
 - fix default worker autoscaling_enabled not working (by @erks)
 - Cosmetic syntax changes to improve readability. (by @max-rocket-internet)

README.md

@@ -104,7 +104,6 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a
 | cluster_security_group_id | If provided, the EKS cluster will be attached to this security group. If not given, a security group will be created with necessary ingres/egress to work with the workers and provide API access to your current IP/32. | string | `` | no |
 | cluster_version | Kubernetes version to use for the EKS cluster. | string | `1.10` | no |
 | config_output_path | Determines where config files are placed if using configure_kubectl_session and you want config files to land outside the current working directory. Should end in a forward slash / . | string | `./` | no |
-| create_elb_service_linked_role | Whether to create the service linked role for the elasticloadbalancing service. Without this EKS cannot create ELBs. | string | `false` | no |
 | kubeconfig_aws_authenticator_additional_args | Any additional arguments to pass to the authenticator such as the role to assume. e.g. ["-r", "MyEksRole"]. | list | `<list>` | no |
 | kubeconfig_aws_authenticator_command | Command to use to to fetch AWS EKS credentials. | string | `aws-iam-authenticator` | no |
 | kubeconfig_aws_authenticator_env_variables | Environment variables that should be used when executing the authenticator. e.g. { AWS_PROFILE = "eks"}. | map | `<map>` | no |

cluster.tf

@@ -63,8 +63,3 @@ resource "aws_iam_role_policy_attachment" "cluster_AmazonEKSServicePolicy" {
   policy_arn = "arn:aws:iam::aws:policy/AmazonEKSServicePolicy"
   role       = "${aws_iam_role.cluster.name}"
 }
-
-resource "aws_iam_service_linked_role" "elasticloadbalancing" {
-  count            = "${var.create_elb_service_linked_role}"
-  aws_service_name = "elasticloadbalancing.amazonaws.com"
-}

variables.tf

@@ -22,11 +22,6 @@ variable "write_kubeconfig" {
   default     = true
 }
 
-variable "create_elb_service_linked_role" {
-  description = "Whether to create the service linked role for the elasticloadbalancing service. Without this EKS cannot create ELBs."
-  default     = false
-}
-
 variable "manage_aws_auth" {
   description = "Whether to write and apply the aws-auth configmap file."
   default     = true