github-mirrors/odc-analyzer
1
0
Fork 0
mirror of https://github.com/ysoftdevs/odc-analyzer.git synced 2026-03-25 18:42:07 +01:00
Code Issues 2 Packages Projects Releases Wiki Activity

Fixed some leftover mess

Browse Source
This commit is contained in:
Šesták Vít
2016-04-07 20:46:19 +02:00
parent 1ae9aec9d4
commit b35db5bd52
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/controllers/Notifications.scala
View File

@@ -102,14 +102,13 @@ class Notifications @Inject()(
private object FailedProjects { private object FailedProjects {
// TODO: Move elsewhere // TODO: Move elsewhere
def combineFails(failedReportDownloads: Map[String, Throwable], parsingFailures: Map[ReportInfo, Throwable], failedBuilds: Map[String, (Build, ArtifactItem, ArtifactFile)]): FailedProjects = { def combineFails(failedReportDownloads: Map[String, Throwable], parsingFailures: Map[ReportInfo, Throwable]): FailedProjects = {
/* /*
Fail can happen at multiple places: Fail can happen at multiple places:
1. Build cannot be downloaded (auth error, connection error, …) or is failed (failedReportDownloads) 1. Build cannot be downloaded (auth error, connection error, …) or is failed (failedReportDownloads)
2. Build can be downloaded, but it is failed (failedBuilds) – as this is source-specific, this will be probably moved to Downloader's responsibility. 2. Build is successful and can be downloaded, but it cannot be parsed (parsingFailures)
3. Build is successful and can be downloaded, but it cannot be parsed (parsingFailures)
*/ */
val failedProjectsSet = failedReportDownloads.keySet ++ parsingFailures.keySet.map(_.projectId) ++ failedBuilds.keySet val failedProjectsSet = failedReportDownloads.keySet ++ parsingFailures.keySet.map(_.projectId)
new FailedProjects(failedProjectsSet) new FailedProjects(failedProjectsSet)
} }
} }