From b35db5bd52177832f712f5994ae8b9d467a71deb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0est=C3=A1k=20V=C3=ADt?= Date: Thu, 7 Apr 2016 20:46:19 +0200 Subject: [PATCH] Fixed some leftover mess --- app/controllers/Notifications.scala | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/app/controllers/Notifications.scala b/app/controllers/Notifications.scala index 131210e..56fc8f3 100644 --- a/app/controllers/Notifications.scala +++ b/app/controllers/Notifications.scala @@ -102,14 +102,13 @@ class Notifications @Inject()( private object FailedProjects { // TODO: Move elsewhere - def combineFails(failedReportDownloads: Map[String, Throwable], parsingFailures: Map[ReportInfo, Throwable], failedBuilds: Map[String, (Build, ArtifactItem, ArtifactFile)]): FailedProjects = { + def combineFails(failedReportDownloads: Map[String, Throwable], parsingFailures: Map[ReportInfo, Throwable]): FailedProjects = { /* Fail can happen at multiple places: 1. Build cannot be downloaded (auth error, connection error, …) or is failed (failedReportDownloads) - 2. Build can be downloaded, but it is failed (failedBuilds) – as this is source-specific, this will be probably moved to Downloader's responsibility. - 3. Build is successful and can be downloaded, but it cannot be parsed (parsingFailures) + 2. Build is successful and can be downloaded, but it cannot be parsed (parsingFailures) */ - val failedProjectsSet = failedReportDownloads.keySet ++ parsingFailures.keySet.map(_.projectId) ++ failedBuilds.keySet + val failedProjectsSet = failedReportDownloads.keySet ++ parsingFailures.keySet.map(_.projectId) new FailedProjects(failedProjectsSet) } }