github-mirrors/oauth-playground-client
1
0
Fork 0
mirror of https://github.com/ysoftdevs/oauth-playground-client.git synced 2026-01-11 14:30:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

[PR #1] [MERGED] Fix PKCE's URL-safe Base64 encoding #1

New Issue
Closed
opened 2025-12-31 16:29:20 +01:00 by adam · 0 comments
adam commented 2025-12-31 16:29:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ysoftdevs/oauth-playground-client/pull/1
Author: @zdenek-biberle
Created: 12/6/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @xRodney

Base: main ← Head: base64url

📝 Commits (1)

  • 4474cc4 Fix PKCE's URL-safe Base64 encoding

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/flow/pkce.html (+2 -2)

📄 Description

Bertík just got bit by this. He didn't notice that the challenge was incorrectly encoded and was wondering why his PKCE implementation didn't work. Very sad.

obrazek

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ysoftdevs/oauth-playground-client/pull/1 **Author:** [@zdenek-biberle](https://github.com/zdenek-biberle) **Created:** 12/6/2023 **Status:** ✅ Merged **Merged:** 12/6/2023 **Merged by:** [@xRodney](https://github.com/xRodney) **Base:** `main` ← **Head:** `base64url` --- ### 📝 Commits (1) - [`4474cc4`](https://github.com/ysoftdevs/oauth-playground-client/commit/4474cc42a6bbbf1cbd7e9cccc243dcb6873f7ba9) Fix PKCE's URL-safe Base64 encoding ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/flow/pkce.html` (+2 -2) </details> ### 📄 Description Bertík just got bit by this. He didn't notice that the challenge was incorrectly encoded and was wondering why his PKCE implementation didn't work. Very sad. ![obrazek](https://github.com/ysoftdevs/oauth-playground-client/assets/1297565/924fd4b6-e007-4d3b-add3-bc0dcd73f695) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-31 16:29:20 +01:00
adam closed this issue 2025-12-31 16:29:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-mirrors/oauth-playground-client#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?