checkstyle fixes

Former-commit-id: 2bd6f330836c7dab07e5968ef845b4d48ede4abe
This commit is contained in:
Jeremy Long
2013-04-18 06:54:36 -04:00
parent ec9f4b2b61
commit e24a62d621
6 changed files with 16 additions and 14 deletions

View File

@@ -26,8 +26,8 @@ import org.owasp.dependencycheck.dependency.Dependency;
import org.owasp.dependencycheck.dependency.Identifier;
/**
* This analyzer attempts to remove some well known false positives - specifically
* regarding the java runtime.
* This analyzer attempts to remove some well known false positives -
* specifically regarding the java runtime.
*
* @author Jeremy Long (jeremy.long@gmail.com)
*/
@@ -121,6 +121,7 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer {
/**
* Intended to remove spurious CPE entries.
*
* @param dependency the dependency being analyzed
*/
private void removeVersions(Dependency dependency) {
@@ -128,17 +129,18 @@ public class FalsePositiveAnalyzer extends AbstractAnalyzer {
//cpe: cpe:/a:apache:axis2:1.4
//cpe: cpe:/a:apache:axis:1.4
/* the above was identified from the evidence below:
Source Name Value
Manifest Bundle-Vendor Apache Software Foundation
Manifest Bundle-Version 1.4
file name axis2-kernel-1.4.1
pom artifactid axis2-kernel
pom name Apache Axis2 - Kernel
Source Name Value
Manifest Bundle-Vendor Apache Software Foundation
Manifest Bundle-Version 1.4
file name axis2-kernel-1.4.1
pom artifactid axis2-kernel
pom name Apache Axis2 - Kernel
*/
}
/**
* Removes any CPE entries for the JDK/JRE unless the filename ends with rt.jar
* Removes any CPE entries for the JDK/JRE unless the filename ends with
* rt.jar
*
* @param dependency the dependency to remove JRE CPEs from
*/

View File

@@ -715,7 +715,6 @@ public class JarAnalyzer extends AbstractAnalyzer implements Analyzer {
/**
* Determines if the key value pair from the manifest is for an "import" type
* entry for package names.
*
* @param key the key from the manifest
* @param value the value from the manifest
* @return true or false depending on if it is believed the entry is an "import" entry

View File

@@ -23,7 +23,6 @@ import java.io.IOException;
import java.security.NoSuchAlgorithmException;
import java.util.ArrayList;
import java.util.List;
import java.util.Set;
import java.util.SortedSet;
import java.util.TreeSet;
import java.util.logging.Level;

View File

@@ -128,7 +128,11 @@ public class Reference implements Serializable, Comparable<Reference> {
hash = 67 * hash + (this.source != null ? this.source.hashCode() : 0);
return hash;
}
/**
* Implementation of the comparable interface.
* @param o the Reference being compared
* @return an integer indicating the ordering of the two objects
*/
public int compareTo(Reference o) {
if (source.equals(o.source)) {
if (name.equals(o.name)) {

View File

@@ -19,7 +19,6 @@
package org.owasp.dependencycheck.dependency;
import java.io.Serializable;
import java.util.HashSet;
import java.util.Set;
import java.util.SortedSet;
import java.util.TreeSet;

View File

@@ -27,7 +27,6 @@ import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.OutputStreamWriter;
import java.util.Date;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;