github-mirrors/DependencyCheck
1
0
Fork 0
mirror of https://github.com/ysoftdevs/DependencyCheck.git synced 2026-05-01 12:44:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

checkstyle/pmd/findbugs correction(s)

Browse Source
This commit is contained in:
Jeremy Long
2016-05-15 07:48:26 -04:00
parent 17f810a720
commit 0b26894112
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
View File

@@ -577,9 +577,9 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
addMatchingValues(classes, trimmedDescription, dependency.getVendorEvidence()); addMatchingValues(classes, trimmedDescription, dependency.getVendorEvidence());
addMatchingValues(classes, trimmedDescription, dependency.getProductEvidence()); addMatchingValues(classes, trimmedDescription, dependency.getProductEvidence());
} }
String projectURL = pom.getProjectURL(); String projectURL = pom.getProjectURL();
if(projectURL != null && !projectURL.trim().isEmpty()) { if (projectURL != null && !projectURL.trim().isEmpty()) {
dependency.getVendorEvidence().addEvidence("pom", "url", projectURL, Confidence.HIGHEST); dependency.getVendorEvidence().addEvidence("pom", "url", projectURL, Confidence.HIGHEST);
} }
@@ -645,7 +645,7 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
* @return whether evidence was identified parsing the manifest * @return whether evidence was identified parsing the manifest
* @throws IOException if there is an issue reading the JAR file * @throws IOException if there is an issue reading the JAR file
*/ */
protected boolean parseManifest(Dependency dependency, List<ClassNameInformation> classInformation) protected boolean parseManifest(Dependency dependency, List<ClassNameInformation> classInformation)
throws IOException { throws IOException {
boolean foundSomething = false; boolean foundSomething = false;
JarFile jar = null; JarFile jar = null;
@@ -792,11 +792,10 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
} }
} }
final Map<String, Attributes> entries = manifest.getEntries(); for (Map.Entry<String, Attributes> item : manifest.getEntries().entrySet()) {
for (Iterator<String> it = entries.keySet().iterator(); it.hasNext();) { final String name = item.getKey();
final String name = it.next();
source = "manifest: " + name; source = "manifest: " + name;
atts = entries.get(name); atts = item.getValue();
for (Entry<Object, Object> entry : atts.entrySet()) { for (Entry<Object, Object> entry : atts.entrySet()) {
final String key = entry.getKey().toString(); final String key = entry.getKey().toString();
final String value = atts.getValue(key); final String value = atts.getValue(key);