From 0b26894112ca706d86ec73b08fb00a06826ef7d9 Mon Sep 17 00:00:00 2001
From: Jeremy Long <jeremy.long@gmail.com>
Date: Sun, 15 May 2016 07:48:26 -0400
Subject: [PATCH] checkstyle/pmd/findbugs correction(s)

---
 .../owasp/dependencycheck/analyzer/JarAnalyzer.java | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
index c43cd5c3b..4ffca8773 100644
--- a/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
+++ b/dependency-check-core/src/main/java/org/owasp/dependencycheck/analyzer/JarAnalyzer.java
@@ -577,9 +577,9 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
             addMatchingValues(classes, trimmedDescription, dependency.getVendorEvidence());
             addMatchingValues(classes, trimmedDescription, dependency.getProductEvidence());
         }
-        
+
         String projectURL = pom.getProjectURL();
-        if(projectURL != null && !projectURL.trim().isEmpty()) {
+        if (projectURL != null && !projectURL.trim().isEmpty()) {
             dependency.getVendorEvidence().addEvidence("pom", "url", projectURL, Confidence.HIGHEST);
         }
 
@@ -645,7 +645,7 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
      * @return whether evidence was identified parsing the manifest
      * @throws IOException if there is an issue reading the JAR file
      */
-    protected boolean parseManifest(Dependency dependency, List<ClassNameInformation> classInformation) 
+    protected boolean parseManifest(Dependency dependency, List<ClassNameInformation> classInformation)
             throws IOException {
         boolean foundSomething = false;
         JarFile jar = null;
@@ -792,11 +792,10 @@ public class JarAnalyzer extends AbstractFileTypeAnalyzer {
                 }
             }
 
-            final Map<String, Attributes> entries = manifest.getEntries();
-            for (Iterator<String> it = entries.keySet().iterator(); it.hasNext();) {
-                final String name = it.next();
+            for (Map.Entry<String, Attributes> item : manifest.getEntries().entrySet()) {
+                final String name = item.getKey();
                 source = "manifest: " + name;
-                atts = entries.get(name);
+                atts = item.getValue();
                 for (Entry<Object, Object> entry : atts.entrySet()) {
                     final String key = entry.getKey().toString();
                     final String value = atts.getValue(key);